Opened 3 months ago
#26436 new defect
Check uses of CMP_SEMANTIC for IP addresses
| Reported by: | teor | Owned by: | |
|---|---|---|---|
| Priority: | Medium | Milestone: | Tor: unspecified |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Normal | Keywords: | tor-dirauth, ipv6, 033-triage-20180320, 033-removed-20180320 |
| Cc: | neel@… | Actual Points: | |
| Parent ID: | #24546 | Points: | |
| Reviewer: | Sponsor: |
Description
From #24546 comment 1:
We should also audit all uses of tor_addr_compare(a1, a2, CMP_EXACT) to see if they should be CMP_SEMANTIC instead.
The current uses of CMP_SEMANTIC seem reasonable, but not essential: they code would still work if we rejected mapped addresses and did exact comparisons instead.
Child Tickets
Note: See
TracTickets for help on using
tickets.
