#26437 closed defect (fixed)

Forking tests fails on Windows if there is a space in the path of the test runner

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Tests that needs to fork fails on Windows if there is a space somewhere in the path.

Child Tickets

Change History (9)

comment:1 Changed 11 months ago by ahf

Patch in https://github.com/torproject/tor/pull/165 - let us see what appveyor says before we mark this as needs_reviews.

comment:2 Changed 11 months ago by ahf

Status: newneeds_review

Looks like this didn't cause more troubles. Requesting review.

comment:3 Changed 11 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.5.x-final

comment:4 Changed 11 months ago by asn

Reviewer: asn

comment:5 Changed 11 months ago by asn

Status: needs_reviewneeds_revision

Seems like AppVeyor checks are still failing here even tho the patch looks reasonable. Requesting revision.

Last edited 11 months ago by asn (previous) (diff)

comment:6 Changed 10 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:7 Changed 10 months ago by ahf

Status: needs_revisionneeds_review

Looks like AppVeyor is happy after a rebase: https://ci.appveyor.com/project/torproject/tor/build/1.0.390

comment:8 Changed 10 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:9 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

lgtm; merged to master.

Note: See TracTickets for help on using tickets.