Opened 4 months ago

Closed 4 months ago

#26438 closed defect (fixed)

Remove our seatbelt profiles for macOS for now

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The sandbox we ship for macOS is broken for a while now (see #22000) we should not ship it anymore until we fix it as this is confusing to users and gives a broken experience.

Child Tickets

Change History (3)

comment:1 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

comment:2 Changed 4 months ago by gk

If I see that right we never made a distinction between the background.png and .DS_Store files we ship on master and on maint- branches when switching to tor-browser-build which means we always shipped the ones for the sandbox.

The reason why this in the end did not matter was that we (or at least I) used the non-sandboxed ones on my build box when recreating the .dmg files after signing.

So, I added another commit to the bug_26438 branch (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26438&id=8b91968072326cf32da011b2c8bd3bbef14e4ef4) replacing the sandboxed background image etc. with the non-sandboxed ones.

comment:3 Changed 4 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged both commits to master as 767dd879b91584d5828998804ab1ee45499ca640 and 8b91968072326cf32da011b2c8bd3bbef14e4ef4.

Note: See TracTickets for help on using tickets.