Opened 3 months ago

Closed 3 months ago

#26439 closed defect (wontfix)

Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Hello71 pointed this out to me on a code review.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by nickm

Implementation in branch ticket26439; PR at https://github.com/torproject/tor/pull/166

comment:2 Changed 3 months ago by nickm

Keywords: fast-fix added
Status: assignedneeds_review

comment:3 Changed 3 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewneeds_revision

This branch is failing to build on Travis. Also there are merge commit in it?...

comment:4 Changed 3 months ago by nickm

I think it was based on a bad master. Hang on a second... I just force-pushed a replacement.

comment:5 Changed 3 months ago by nickm

Status: needs_revisionneeds_review

comment:6 Changed 3 months ago by dgoulet

Status: needs_reviewmerge_ready

Only commit 56c1fbf33f34e010 currently applies to master since the rest has been merged upstream I believe through another ticket.

This lgtm;

comment:7 Changed 3 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to master!

comment:8 Changed 3 months ago by nickm

Resolution: implemented
Status: closedreopened

Reverted this with 0742b387253f25: it seems to break appveyor, which produces lots of messages like:

chmod
: cannot access 'link_rust.sh': No such file or directory
chmod
: cannot access 'contrib/dist/tor.sh': No such file or directory
chmod
: cannot access 'contrib/dist/torctl': No such file or directory
chmod
: cannot access 'scripts/maint/checkOptionDocs.pl': No such file or directory
chmod

comment:9 Changed 3 months ago by nickm

Resolution: wontfix
Status: reopenedclosed

Since our previous (ugly) approach worked, and this approach (though supported!) didn't, I'm going to call this wontfix -- but please reopen if you know a way around the windows issues noted above.

Note: See TracTickets for help on using tickets.