Opened 9 years ago

Closed 8 years ago

#2645 closed defect (fixed)

HTTPS Everywhere 0.9.4 ignores rulesets with XML declaration

Reported by: cypherpunks Owned by: pde
Priority: Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: jacobske87@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Rulesets starting with an XML declaration (c.f. http://www.w3.org/TR/xml/#sec-prolog-dtd ) are silently ignored by HTTPS Everywhere 0.9.4.

For example:

<?xml version="1.0" encoding="utf-8"?>
<ruleset name="Newit.co.uk">

<target host="newit.co.uk"/>
<target host="www.newit.co.uk"/>
<rule from="http://(www\.)?newit\.co\.uk\b" to="https://www.newit.co.uk"/>

</ruleset>

With the XML declaration, no HTTP->HTTPS redirection takes place, and the ruleset isn't listed in the add-on preferences. Remove the declaration and it works.

Child Tickets

Attachments (1)

HTTPSRules.js (11.6 KB) - added by jacobske87 8 years ago.
Fix on line 181

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by pde

Priority: normalminor
Status: newaccepted

It'd be great to receive a patch for this ;)

Changed 8 years ago by jacobske87

Attachment: HTTPSRules.js added

Fix on line 181

comment:2 Changed 8 years ago by jacobske87

I was having trouble getting the Git repository to commit (I'm an SVN user - a new one at that) - but I attached the file. Fix is on line 181 and should probably be above the try{, but it works for me.

Hope it helps.

comment:3 Changed 8 years ago by jacobske87

Cc: jacobske87@… added

comment:4 Changed 8 years ago by pde

Resolution: fixed
Status: acceptedclosed

This is now fixed in the development release, and the change should migrate over to stable too soon.

Note: See TracTickets for help on using tickets.