Opened 2 years ago

Closed 2 years ago

#26459 closed defect (wontfix)

netinet/tcp.h autoconf test is missing u_int32_t on cygwin

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor:
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: #26356 Points:
Reviewer: Sponsor:


I think we need to add sys/types.h on Cygwin, and maybe BSD/macOS as well.
But if this configure test is only for KIST, and KIST only works on Linux, maybe we don't need to fix this issue.

configure:9774: checking for struct tcp_info.tcpi_unacked
configure:9774: gcc -c -g -O2   -I${top_srcdir}/src/common conftest.c >&5
In file included from conftest.c:77:
/usr/include/netinet/tcp.h:42:9: error: unknown type name 'u_int32_t'
 typedef u_int32_t tcp_seq;

(similar errors)

configure:9774: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "tor"
| #define PACKAGE_TARNAME "tor"
| #define PACKAGE_VERSION ""

(similar macros)

| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1

(similar macros)

| /* end confdefs.h.  */
| #include <netinet/tcp.h>
| int
| main ()
| {
| static struct tcp_info ac_aggr;
| if (ac_aggr.tcpi_unacked)
| return 0;
|   ;
|   return 0;
| }

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by teor

Version: Tor:

comment:2 Changed 2 years ago by teor

Resolution: wontfix
Status: newclosed

pastly confirmed on #tor-dev that KIST only works on Linux (and Linux Subsystem for Windows).
Even if we eventually implement it on Cygwin, macOS, or BSD, we'll need a different configure test.

Note: See TracTickets for help on using tickets.