Opened 15 months ago

Closed 15 months ago

Last modified 12 months ago

#26462 closed defect (fixed)

Build of firefox 60.1.0 fails on linux32

Reported by: boklm Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-rbm, TorBrowserTeam201806R, GeorgKoppen201806
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

My build of tor-browser tbb-8.0a9-build1 fails on linux32 with the following error:

22:10.69 libdom_canvas.a.desc
23:08.63    Compiling geckoservo v0.0.1 (file:///var/tmp/build/firefox-c6cbbca92205/servo/ports/geckolib)
24:15.11    Compiling gkrust-shared v0.1.0 (file:///var/tmp/build/firefox-c6cbbca92205/toolkit/library/rust/shared)
24:15.57    Compiling gkrust v0.1.0 (file:///var/tmp/build/firefox-c6cbbca92205/toolkit/library/rust)
26:11.74 error: failed to build archive: Cannot allocate memory
26:11.74 
26:11.74 error: aborting due to previous error
26:11.74 
26:11.77 error: Could not compile `gkrust`.
26:11.77 
26:11.77 To learn more, run the command again with --verbose.
26:11.77 make[4]: *** [force-cargo-library-build] Error 101
26:11.77 make[3]: *** [toolkit/library/rust/target] Error 2
26:11.77 make[2]: *** [compile] Error 2
26:11.77 make[1]: *** [default] Error 2
26:11.77 make: *** [build] Error 2

It might be related to #26323.

Child Tickets

Change History (6)

comment:1 Changed 15 months ago by boklm

GeKo suggested disabling stylo in the linux32 build, as a workaround until we have more time to fix the underlying problem. So I am now trying a build with stylo disabled.

comment:2 in reply to:  1 ; Changed 15 months ago by gk

Keywords: ff60-esr tbb-rbm TorBrowserTeam201806R GeorgKoppen201806 added; TorBrowserTeam201806 removed
Status: newneeds_review

Replying to boklm:

GeKo suggested disabling stylo in the linux32 build, as a workaround until we have more time to fix the underlying problem. So I am now trying a build with stylo disabled.

That's not enough due to libxul linking errors. Apart from that I think I have a better idea: let's just omit the 32bit debug info for Firefox for now. It seems to me not that important anyway, given that we have 64bit debug symbols for Linux and it allows to keep our build configuration at least as far as end users are concerned and as far as we have shipped bundles in our nightlies over the past couple of weeks.

bug_26462 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26462&id=71b71dbabf48db4b1a986b979f01d9bf6c79c30d) in my public tor-browser-build repo has a patch for review which works for me.

comment:3 Changed 15 months ago by gk

FWIW: https://bugzilla.mozilla.org/show_bug.cgi?id=1401093 has quite some useful considerations, for instance glandium's comment:

Well, linux distros tend to not cross-build so they would build 32-bits binaries on 32-bits OSes. What I do on Debian is add -Wl,--reduce-memory-overheads -Wl,--no-keep-memory to LDFLAGS. Maybe we could do that automatically.

comment:4 in reply to:  2 Changed 15 months ago by boklm

Replying to gk:

Replying to boklm:

GeKo suggested disabling stylo in the linux32 build, as a workaround until we have more time to fix the underlying problem. So I am now trying a build with stylo disabled.

That's not enough due to libxul linking errors. Apart from that I think I have a better idea: let's just omit the 32bit debug info for Firefox for now. It seems to me not that important anyway, given that we have 64bit debug symbols for Linux and it allows to keep our build configuration at least as far as end users are concerned and as far as we have shipped bundles in our nightlies over the past couple of weeks.

bug_26462 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26462&id=71b71dbabf48db4b1a986b979f01d9bf6c79c30d) in my public tor-browser-build repo has a patch for review which works for me.

There is a typo in the commit message: nightlis instead of nightlies.

Otherwise the patch looks good to me.

comment:5 Changed 15 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed and merged to master (commit 7dc74d1652c560e193d1a4c3331efcfb08ee67b0).

comment:6 Changed 12 months ago by traumschule

comment:2:ticket:26323 has more info

Note: See TracTickets for help on using tickets.