Tor Browser candidates for 8.0a9 on Windows don't start anymore

Suddenly our Windows bundles are not starting anymore, both 32bit and 64bit.

added GeorgKoppen201806 TorBrowserTeam201806 component::applications/tor browser owner::tbb-team priority::immediate resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

Trac:
Summary: Tor Browser candidates for 8.0a8 on Windows don't start anymore to Tor Browser candidates for 8.0a9 on Windows don't start anymore

The first one that is broken is the nightly from yestderday. From 6/22 it is still working. Probably something in our rebase to 60.1.0esr broke, sigh.

Testing essentially 60.1.0esr with bug_26476_test1.

The good news is it's not one of our patches or the rebase that broke Windows builds. The bad news is that it seems to be some Mozilla commit:

bug_26476_test2 is based on a59817849caddc8475595855a03f7dcf5c4ba855 which works bug_26476_test1 is based on f4f2ffd2aa14ca8a144e9fc8d773fca4c040e3f5 which is broken

+          default=milestone.is_release_or_beta,

is the line that is crashing the Windows builds on start-up. This got added in https://bugzilla.mozilla.org/show_bug.cgi?id=1467041. I guess we should back out the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1464084 as well as crashes were seen without the former but the latter. I am testing a fix right now.

bug_26476 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26476&id=43cefe3afeb58e7416f7b1e508c8a251b12efb72) works for me. I merged it to master (commit 43cefe3afeb58e7416f7b1e508c8a251b12efb72). I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1470772 to track the issue on Mozilla's side.

Trac:
Status: new to closed
Keywords: N/A deleted, GeorgKoppen201806, tbb-rbm added
Resolution: N/A to fixed

This is the ulimit problem I am grappling with:

In the build log:

22:54.42 /var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld: cannot find /var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/crtend.o: Too many open files

In the container:

debug-firefox$ ulimit -n 1024

Outside the container:

cat /etc/security/limits.conf

tom hard nofile 65535 tom soft nofile 65535 root hard nofile 65535 root soft nofile 65535

Okay I fixed that ulimit problem. Bisecting/debugging continues.

Replying to tom:

Okay I fixed that ulimit problem.

How did you fix it?

See #26861 (moved) for anyone wondering this in the future.

Trac:
Cc: boklm to boklm, pospeselr

Isn't it about https://sourceware.org/bugzilla/show_bug.cgi?id=11539#c20?

Trac:
Username: rlimit

closed

mentioned in issue #26484 (moved)

mentioned in issue #27865 (moved)

mentioned in issue #28618 (moved)

moved to tpo/applications/tor-browser#26476 (closed)