Opened 3 months ago

Closed 3 months ago

Last modified 4 weeks ago

#26476 closed defect (fixed)

Tor Browser candidates for 8.0a9 on Windows don't start anymore

Reported by: gk Owned by: tbb-team
Priority: Immediate Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201806, GeorgKoppen201806, tbb-rbm
Cc: boklm, pospeselr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Suddenly our Windows bundles are not starting anymore, both 32bit and 64bit.

Child Tickets

Change History (12)

comment:1 Changed 3 months ago by gk

Summary: Tor Browser candidates for 8.0a8 on Windows don't start anymoreTor Browser candidates for 8.0a9 on Windows don't start anymore

comment:2 Changed 3 months ago by gk

The first one that is broken is the nightly from yestderday. From 6/22 it is still working. Probably something in our rebase to 60.1.0esr broke, sigh.

comment:3 Changed 3 months ago by gk

Testing essentially 60.1.0esr with bug_26476_test1.

comment:4 Changed 3 months ago by gk

The good news is it's not one of our patches or the rebase that broke Windows builds. The bad news is that it seems to be some Mozilla commit:

bug_26476_test2 is based on a59817849caddc8475595855a03f7dcf5c4ba855 which works
bug_26476_test1 is based on f4f2ffd2aa14ca8a144e9fc8d773fca4c040e3f5 which is broken

comment:5 Changed 3 months ago by gk

+          default=milestone.is_release_or_beta,

is the line that is crashing the Windows builds on start-up. This got added in https://bugzilla.mozilla.org/show_bug.cgi?id=1467041. I guess we should back out the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1464084 as well as crashes were seen without the former but the latter. I am testing a fix right now.

comment:6 Changed 3 months ago by gk

Keywords: GeorgKoppen201806 tbb-rbm added
Resolution: fixed
Status: newclosed

bug_26476 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26476&id=43cefe3afeb58e7416f7b1e508c8a251b12efb72) works for me. I merged it to master (commit 43cefe3afeb58e7416f7b1e508c8a251b12efb72).
I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1470772 to track the issue on Mozilla's side.

comment:7 Changed 2 months ago by tom

This is the ulimit problem I am grappling with:

In the build log:

22:54.42 /var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/../../../../x86_64-w64-mingw32/bin/ld: cannot find /var/tmp/dist/mingw-w64/lib/gcc/x86_64-w64-mingw32/6.4.0/crtend.o: Too many open files

In the container:

debug-firefox$ ulimit -n
1024

Outside the container:

cat /etc/security/limits.conf

tom hard nofile 65535
tom soft nofile 65535
root hard nofile 65535
root soft nofile 65535

comment:8 Changed 2 months ago by tom

Okay I fixed that ulimit problem. Bisecting/debugging continues.

comment:9 in reply to:  8 Changed 8 weeks ago by boklm

Replying to tom:

Okay I fixed that ulimit problem.

How did you fix it?

comment:10 Changed 8 weeks ago by tom

See #26861 for anyone wondering this in the future.

comment:11 Changed 5 weeks ago by pospeselr

Cc: pospeselr added
Note: See TracTickets for help on using tickets.