Meek is broken in ESR60-based Tor Browser

Meek is not working in an ESR60-based Tor Browser. Instead of being able to use this pluggable transport a new browser Window pops up and a bunch of modal dialogs claiming that Tor Browser is already running. This affects Moat as well.

added TorBrowserTeam201807 component::applications/tor browser ff60-esr owner::dcf priority::very high resolution::fixed severity::normal status::closed type::defect labels

Moving first batch of tickets to July 2018

Trac:
Keywords: TorBrowserTeam201806 deleted, TorBrowserTeam201807 added

Trac:

Screenshot of the JavaScript console of the browser window that appears when selecting meek on first startup. Press Ctrl+Shift+J.

I tried it on 8.0a9. I didn't get the "already running" errors mentioned in the ticket description (may be #12774 (moved)?). What I got instead was a big empty browser window and a progress bar stuck at 0%. I opened the JavaScript console in the browser window with Ctrl+Shift+J and got this:

NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]	main.js:43
While creating services from category 'profile-after-change', could not create service for entry 'MeekHTTPHelper', contract ID !'@bamsoftware.com/meek-http-helper;1'
Warning: unrecognized command line flag -invisible	nsBrowserContentHandler.js:837
dch_handle jar:file:///home/david/tor-browser-linux64-8.0a9_en-US/tor-browser_en-US/Browser/browser/omni.ja!/components/nsBrowserContentHandler.js:837:9
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURIWithOptions]	browser-child.js:359

It looks like the two errors are around nsIXPCComponents_Utils.import and nsIWebNavigation.loadURIWithOptions. The error about -invisible seems to be from a changed command-line interface (meek-client-torbrowser passes -invisible to firefox).

Somehow I seem to remember someone telling me that one of the imports had changed in ESR60. But now I can't find any record of it. Anyway, I think it was about needing to change the current

Components.utils.import("re[/gre/modules/devtools/Console.jsm");](/gre/modules/devtools/Console.jsm");)

to

Components.utils.import("re[/gre/modules/Console.jsm");](/gre/modules/Console.jsm");)

as is now documented at https://developer.mozilla.org/en-US/docs/Tools/Browser_Console#Console.jsm. That may explain the first import failure.

I found who told me about the Console.jsm change. It was sysrqb in #26118 (moved).

Could you try this bug26477 branch? It changes re[/gre/modules/devtools/Console.jsm](/gre/modules/devtools/Console.jsm) to re[/gre/modules/Console.jsm](/gre/modules/Console.jsm) as suggested. It worked for me just now (I unpacked !meek-http-helper@bamsoftware.com.xpi, made the change, and zipped it up again).

The warning about -invisible doesn't seem to cause a problem; the browser window wasn't visible.

Trac:
Status: new to needs_review

Replying to dcf:

I found who told me about the Console.jsm change. It was sysrqb in #26118 (moved).

Could you try this bug26477 branch?

This fixes the problem for me, thanks. Closing #26118 (moved) as duplicate as there is more meat in this ticket. dcf: could you give us a new meek tag with this change and we can bump the version we ship in tor-browser-build?

Trac:
Status: needs_review to assigned
Owner: tbb-team to dcf

Trac:
Cc: dcf, mcs, brade to dcf, mcs, brade, sysrqb

Replying to gk:

dcf: could you give us a new meek tag with this change and we can bump the version we ship in tor-browser-build?

I tagged 0.31.

Thanks! Updated in commit ed1755732939ec95b14b501eb82c799b7756ef2a on master.

Trac:
Resolution: N/A to fixed
Status: assigned to closed

Resolved #27144 (moved) as a duplicate.

Trac:
Cc: dcf, mcs, brade, sysrqb to dcf, mcs, brade, sysrqb, Dbryrtfbcbhgf

closed

mentioned in issue #26652 (moved)

mentioned in issue #27144 (moved)

moved to tpo/applications/tor-browser#26477 (closed)