Opened 16 months ago

Closed 15 months ago

Last modified 14 months ago

#26477 closed defect (fixed)

Meek is broken in ESR60-based Tor Browser

Reported by: gk Owned by: dcf
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201807
Cc: dcf, mcs, brade, sysrqb, Dbryrtfbcbhgf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Meek is not working in an ESR60-based Tor Browser. Instead of being able to use this pluggable transport a new browser Window pops up and a bunch of modal dialogs claiming that Tor Browser is already running. This affects Moat as well.

Child Tickets

Attachments (1)

tb-8.0a9-meek-js-console.png (46.9 KB) - added by dcf 15 months ago.
Screenshot of the JavaScript console of the browser window that appears when selecting meek on first startup. Press Ctrl+Shift+J.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 16 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

Moving first batch of tickets to July 2018

Changed 15 months ago by dcf

Screenshot of the JavaScript console of the browser window that appears when selecting meek on first startup. Press Ctrl+Shift+J.

comment:2 Changed 15 months ago by dcf

I tried it on 8.0a9. I didn't get the "already running" errors mentioned in the ticket description (may be #12774?). What I got instead was a big empty browser window and a progress bar stuck at 0%. I opened the JavaScript console in the browser window with Ctrl+Shift+J and got this:
Screenshot of the JavaScript console of the browser window that appears when selecting meek on first startup. Press Ctrl+Shift+J.

NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import] main.js:43
While creating services from category 'profile-after-change', could not create service for entry 'MeekHTTPHelper', contract ID '@bamsoftware.com/meek-http-helper;1'
Warning: unrecognized command line flag -invisible nsBrowserContentHandler.js:837
dch_handle jar:file:///home/david/tor-browser-linux64-8.0a9_en-US/tor-browser_en-US/Browser/browser/omni.ja!/components/nsBrowserContentHandler.js:837:9
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURIWithOptions] browser-child.js:359

It looks like the two errors are around nsIXPCComponents_Utils.import and nsIWebNavigation.loadURIWithOptions. The error about -invisible seems to be from a changed command-line interface (meek-client-torbrowser passes -invisible to firefox).

Somehow I seem to remember someone telling me that one of the imports had changed in ESR60. But now I can't find any record of it. Anyway, I think it was about needing to change the current

Components.utils.import("resource://gre/modules/devtools/Console.jsm");

to

Components.utils.import("resource://gre/modules/Console.jsm");

as is now documented at https://developer.mozilla.org/en-US/docs/Tools/Browser_Console#Console.jsm. That may explain the first import failure.

comment:3 Changed 15 months ago by dcf

Status: newneeds_review

I found who told me about the Console.jsm change. It was sysrqb in #26118.

Could you try this bug26477 branch? It changes resource://gre/modules/devtools/Console.jsm to resource://gre/modules/Console.jsm as suggested. It worked for me just now (I unpacked meek-http-helper@bamsoftware.com.xpi, made the change, and zipped it up again).

The warning about -invisible doesn't seem to cause a problem; the browser window wasn't visible.

comment:4 in reply to:  3 ; Changed 15 months ago by gk

Owner: changed from tbb-team to dcf
Status: needs_reviewassigned

Replying to dcf:

I found who told me about the Console.jsm change. It was sysrqb in #26118.

Could you try this bug26477 branch?

This fixes the problem for me, thanks. Closing #26118 as duplicate as there is more meat in this ticket.
dcf: could you give us a new meek tag with this change and we can bump the version we ship in tor-browser-build?

comment:5 Changed 15 months ago by gk

Cc: sysrqb added

comment:6 in reply to:  4 Changed 15 months ago by dcf

Replying to gk:

dcf: could you give us a new meek tag with this change and we can bump the version we ship in tor-browser-build?

I tagged 0.31.

comment:7 Changed 15 months ago by gk

Resolution: fixed
Status: assignedclosed

Thanks! Updated in commit ed1755732939ec95b14b501eb82c799b7756ef2a on master.

comment:8 Changed 14 months ago by gk

Cc: Dbryrtfbcbhgf added

Resolved #27144 as a duplicate.

Note: See TracTickets for help on using tickets.