Opened 7 months ago

Last modified 6 weeks ago

#26478 new defect

Unify bandwidth related terms in dir-spec and Tor code.

Reported by: juga Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-bwauth, refactor, 040-roadmap-proposed
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Unifying these terms would make following what these bandwidth do in the code and the spec less confusing.
For instance:

  • what is called bandwidthrate [0] in the code when building the descriptor, it is called bandwidth-avg in dir-spec.txt [1].
  • what is called bandwidthcapacity [2] in the code, it is called bandwidth-observed in dir-spec.txt[1]

I don't know if it is prefered to modify terms in the spec or in the code.

It'd be also helpful to add formulae or more detailed descriptions on how the different bandwidth terms are generated in dir-spec.txt

[0]https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2370
[1]https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n427
[2] https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2376

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by teor

Keywords: 035-proposed added
Milestone: Tor: unspecified

comment:2 Changed 6 months ago by nickm

Keywords: 035-roadmap-proposed added; 035-proposed removed

comment:3 Changed 3 months ago by juga

Keywords: refactor added

comment:4 Changed 6 weeks ago by teor

Keywords: 040-roadmap-proposed added; 035-roadmap-proposed removed
Milestone: Tor: unspecifiedTor: 0.4.0.x-final

These features or long-term bug fixes probably won't make it into 0.3.5

Note: See TracTickets for help on using tickets.