Opened 2 years ago

Closed 14 months ago

#26484 closed enhancement (fixed)

Remove the Windows bustage workaround implemented in #26476

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff60-esrm TorBrowserTeam201901
Cc: boklm, sukhbir Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


We needed to back out ESR60 commits in the last minute to unblock our alpha build. We should remove the workaround once is fixed on Mozilla's side.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by tom

Would it be possible to get a ./mach build --verbose > build-log.txt of a crashing build?

comment:2 Changed 2 years ago by tom

I think the things to investigate are:

  • -ffunction-sections
  • -fdata-sections
  • -Wl,--icf=safe -Wl,--print-icf-sections
  • -Wl,--gc-sections
  • cargo_rustc_flags += -C lto

comment:3 Changed 2 years ago by tom

My build is missing --icf=safe (because the linker doesn't support it) and RUSTC_OPT_LEVEL is unknown. The other flags are present.

comment:4 Changed 2 years ago by gk

Cc: sukhbir added
Keywords: ff60-esr added

comment:5 Changed 14 months ago by gk

Keywords: ff60-esrm TorBrowserTeam201901 added; ff60-esr removed
Resolution: fixed
Status: newclosed

This got actually done by fixing #28618.

Note: See TracTickets for help on using tickets.