Opened 3 months ago

Closed 4 weeks ago

#26490 closed defect (fixed)

When first launching 8.0a9 the screen.height starts at 612px

Reported by: cypherpunks Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201808R
Cc: arthuredelstein, antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Probably due to the Torbutton notification with the something like "Hey you can change security settings" message on first launch

Child Tickets

Change History (15)

comment:1 Changed 3 months ago by cypherpunks

Also the Torbutton icon doesn't appear on that notification contrary to 7.x version and earlier.

comment:2 Changed 3 months ago by gk

Cc: arthuredelstein added
Keywords: ff60-esr TorBrowserTeam201806 added
Priority: MediumVery High
Status: newneeds_information

Good points. On what platform did you test?

comment:3 Changed 3 months ago by cypherpunks

Debian here

comment:4 in reply to:  description Changed 3 months ago by cypherpunks

Status: needs_informationnew

Replying to cypherpunks:

Probably due to the Torbutton notification with the something like "Hey you can change security settings" message on first launch

Indeed. NI/Restart helps. Windows 10.

comment:5 Changed 3 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

Moving first batch of tickets to July 2018

comment:6 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:7 Changed 5 weeks ago by gk

Status: newneeds_information

Okay, back to this ticket: I need some info to look closer at the window sizing problem: how did you determine that the height started with 612px? Did you look up a website after start, which showed that in turn? If so, which one?

comment:8 in reply to:  7 Changed 5 weeks ago by ProTipGuyFWIWWeLoveARMA

Replying to gk:

Okay, back to this ticket:

Your humble original reporter here:

I need some info to look closer at the window sizing problem: how did you determine that the height started with 612px? Did you look up a website after start, which showed that in turn? If so, which one?

Opening new tab, going to https://fpcentral.tbb.torproject.org/fp and doing the do doing.

PS: I can't change the ticket to new due to the new ultra-restrictive trac permission changes.

comment:9 Changed 5 weeks ago by gk

Status: needs_informationnew

comment:10 Changed 5 weeks ago by ProTipGuyFWIWWeLoveARMA

Problem doesn't happen with 8.0a10 since with my 1000x600 the new about:tor page shows a scrollbar (unlike the previous ones), the underlining issue is still not solved of course.

comment:11 in reply to:  10 Changed 5 weeks ago by gk

Cc: antonela added
Status: newneeds_information

Replying to ProTipGuyFWIWWeLoveARMA:

Problem doesn't happen with 8.0a10 since with my 1000x600 the new about:tor page shows a scrollbar (unlike the previous ones), the underlining issue is still not solved of course.

Interesting, thanks. What about we just get rid of the notification bar and assume the onboarding we implemented is now responsible for highlighting the security slider to users? Back then we just used the clumsy notification bar approach because we did not have a new feature/general onboarding which would have been the ideal place for it. So, getting rid of it would a) streamline the onboarding and b) solve the root cause of this bug and c) would close #27184. I probably forgot some reasons for doing that. Antonela, what do you think?

comment:12 Changed 5 weeks ago by antonela

What about we just get rid of the notification bar and assume the onboarding we implemented is now responsible for highlighting the security slider to users?

I think this is accurate. Also, once we work on the security settings, we will make sure that the improvements get discovered.

Also, I remember mcs reducing the margin of the title to avoid the scrollbars. I'm ok with it. My mockup is static but our implementations are responsive, so it may vary.

comment:13 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: needs_informationneeds_review

comment:14 Changed 4 weeks ago by mcs

r=mcs
Looks good to me.

comment:15 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, cherry-picked to master (commit 1eb701f4701340c89c9f76ad2eb6ae86ca051e61)

Note: See TracTickets for help on using tickets.