Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#26492 closed enhancement (fixed)

code style improvements for src/rust/protover/ffi.rs

Reported by: frewsxcv Owned by:
Priority: Very Low Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Trivial Keywords: 035-triaged-in-20180711
Cc: frewsxcv Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:

Description

Was reading through src/rust/protover/ffi.rs and made a few changes along the way. Here's my git branch:

https://github.com/frewsxcv/tor/compare/frewsxcv-stringlist-refactor

Each change is isolated to its own commit.

Child Tickets

Change History (13)

comment:1 Changed 6 months ago by teor

Component: - Select a componentCore Tor/Tor
Milestone: Tor: 0.3.5.x-final
Status: newneeds_review
Version: Tor: unspecified

Hi, thanks for this patch.

Please open a pull request at https://github.com/torproject/tor so our automatic integration tests run on your branch.

comment:2 Changed 6 months ago by asn

Reviewer: isis

comment:3 Changed 5 months ago by asn

Reviewer: isis

comment:4 Changed 5 months ago by asn

Reviewer: catalyst

comment:5 Changed 5 months ago by chelseakomlo

If this person isn't keeping up to date on this PR anymore, I can open a PR for them (or anyone else please feel free). This patch looks good other than what CI would catch.

comment:7 Changed 5 months ago by frewsxcv

Oh I opened a pull request a couple weeks ago: https://github.com/torproject/tor/pull/179

I forgot to link it from here, sorry!

comment:8 in reply to:  7 Changed 5 months ago by catalyst

Replying to frewsxcv:

Oh I opened a pull request a couple weeks ago: https://github.com/torproject/tor/pull/179

I forgot to link it from here, sorry!

Thanks for the link! I found it earlier and have started reviewing already.

comment:9 Changed 5 months ago by catalyst

Status: needs_reviewneeds_revision

Thanks for the patches! I made some review comments on the pull request.

Would you be willing to write a changes file for this? See doc/HACKING/CodingStandards.md for more details about how to do this.

comment:10 Changed 5 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:11 Changed 5 months ago by catalyst

Summary: Refactoring src/rust/protover/ffi.rs.code style improvements for src/rust/protover/ffi.rs

Edited summary to more accurately reflect the work.

comment:12 Changed 5 months ago by catalyst

Status: needs_revisionmerge_ready

Pushed a changes file to the pull request branch.

comment:13 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

lgtm; merged this to master. Thanks frewscxv, and thanks catalyst!

comment:14 Changed 5 months ago by frewsxcv

Thanks for adding in the changes for me catalyst!

Note: See TracTickets for help on using tickets.