Opened 9 months ago

Last modified 3 days ago

#26498 needs_revision defect

Fix bn-BD and es-AR locale for Tor Browser

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-8.5
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

gk wrote:

I actually had to remove bn-BD again as there is an XML entity error in browser.xul (1404:3) related to appMenu-iüdate-available-notification. I did not figure out in the little time I had why this only affects bn-BD nor how to route around it. But I removed the locale in commit bff4fd1fe7a4e1f105973e9af217b8fefc3db392 from master in tor-browser-build.

Child Tickets

Attachments (1)

bn-BD-linux.png (5.4 KB) - added by gk 5 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 months ago by arthuredelstein

Component: - Select a componentApplications/Tor Browser
Owner: set to tbb-team

comment:2 Changed 5 months ago by arthuredelstein

Keywords: TorBrowserTeam201810R added
Status: newneeds_review

I finally found the answer! I needed to add the bn-BD (and es-AR) locales to the chrome.manifest file in torbutton. So here are patches to add both bn-BD and es-AR:

https://github.com/arthuredelstein/torbutton/commit/26498
https://github.com/arthuredelstein/tor-launcher/commit/26498
https://github.com/arthuredelstein/tor-browser-build/commit/26498

So far I have manually tested both locales and they work.

comment:3 Changed 5 months ago by gk

Summary: Fix bn-BD locale for Tor BrowserFix bn-BD and es-AR locale for Tor Browser

comment:4 Changed 5 months ago by gk

Keywords: TorBrowserTeam201810R removed
Status: needs_reviewneeds_revision

Okay, I tested both locales on a Linux and a Windows system. Here is what I did to build the bundles:

1) I created patches with git format-patch for Torbutton and Tor Launcher and applied them during the rbm build process
2) I patched rbm.conf to just build bn-BD and es-AR bundles in addition to en-US ones
3) I committed the Torbutton patch locally
4) I updated my local Torbutton repo to pick up possibly missing bn-BD and es-AR language strings
5) I created a patch (with git format-patch) and applied the updated translations on top of the Torbutton patch up for review during the rbm build.

The bn-BD bundle seems to be missing a font or something as the title bar is just gibberish on Linux (see attachment). On Windows this does not seem to be an issue. I additionally found #28196 which is unrelated to this bug, though.

The es-AR bundle is neither running on Linux nor on Windows I get

Error de análisis XML: entidad indefinida
Ubicación: chrome://browser/content/browser.xul
Línea 41, columna 1:<window id="main-window"

just before the main browser window pops up.

Changed 5 months ago by gk

Attachment: bn-BD-linux.png added

comment:5 in reply to:  4 Changed 5 months ago by gk

Replying to gk:

The es-AR bundle is neither running on Linux nor on Windows I get

Error de análisis XML: entidad indefinida
Ubicación: chrome://browser/content/browser.xul
Línea 41, columna 1:<window id="main-window"

just before the main browser window pops up.

Okay, I fixed that. I did 4) not good enough ignoring the fact that es-AR strings needed to actually get added (not just updated) to the Torbutton repo. After that es-AR looks good to me.

comment:6 in reply to:  4 Changed 4 months ago by arthuredelstein

Replying to gk:

The bn-BD bundle seems to be missing a font or something as the title bar is just gibberish on Linux (see attachment).

Tor Browser does bundle Noto Sans Bengali, and is correctly rendering the bn-BD text in the rest of that window. The problem seems to be that GTK uses system fonts in the title bar but doesn't use our bundled fonts. So if a Bengali font is not installed on the system, then unicode tofu is displayed. (FWIW, I also see this on my Linux system with the zh-CN Tor Browser, because I don't have a Chinese font installed.)

To fix this in general we will need to investigate if it's possible to add the fonts bundled in Tor Browser to the GTK font search path.

comment:7 Changed 7 weeks ago by gk

For issues with bn-BD on Windows 10, see #29257.

comment:8 Changed 3 days ago by gk

Keywords: tbb-8.5 added

I think we can try getting es-AR into 8.5 (making sure we ship the next alpha with that locale enabled).

Note: See TracTickets for help on using tickets.