Opened 16 months ago

Closed 7 months ago

Last modified 7 months ago

#26498 closed defect (fixed)

Fix es-AR locale for Tor Browser

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: GeorgKoppen201903R, tbb-8.5-must-alpha, TorBrowserTeam201904R, GeorgKoppen201904
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

gk wrote:

I actually had to remove bn-BD again as there is an XML entity error in browser.xul (1404:3) related to appMenu-iüdate-available-notification. I did not figure out in the little time I had why this only affects bn-BD nor how to route around it. But I removed the locale in commit bff4fd1fe7a4e1f105973e9af217b8fefc3db392 from master in tor-browser-build.

Child Tickets

Attachments (1)

bn-BD-linux.png (5.4 KB) - added by gk 12 months ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 16 months ago by arthuredelstein

Component: - Select a componentApplications/Tor Browser
Owner: set to tbb-team

comment:2 Changed 12 months ago by arthuredelstein

Keywords: TorBrowserTeam201810R added
Status: newneeds_review

I finally found the answer! I needed to add the bn-BD (and es-AR) locales to the chrome.manifest file in torbutton. So here are patches to add both bn-BD and es-AR:

https://github.com/arthuredelstein/torbutton/commit/26498
https://github.com/arthuredelstein/tor-launcher/commit/26498
https://github.com/arthuredelstein/tor-browser-build/commit/26498

So far I have manually tested both locales and they work.

comment:3 Changed 12 months ago by gk

Summary: Fix bn-BD locale for Tor BrowserFix bn-BD and es-AR locale for Tor Browser

comment:4 Changed 12 months ago by gk

Keywords: TorBrowserTeam201810R removed
Status: needs_reviewneeds_revision

Okay, I tested both locales on a Linux and a Windows system. Here is what I did to build the bundles:

1) I created patches with git format-patch for Torbutton and Tor Launcher and applied them during the rbm build process
2) I patched rbm.conf to just build bn-BD and es-AR bundles in addition to en-US ones
3) I committed the Torbutton patch locally
4) I updated my local Torbutton repo to pick up possibly missing bn-BD and es-AR language strings
5) I created a patch (with git format-patch) and applied the updated translations on top of the Torbutton patch up for review during the rbm build.

The bn-BD bundle seems to be missing a font or something as the title bar is just gibberish on Linux (see attachment). On Windows this does not seem to be an issue. I additionally found #28196 which is unrelated to this bug, though.

The es-AR bundle is neither running on Linux nor on Windows I get

Error de análisis XML: entidad indefinida
Ubicación: chrome://browser/content/browser.xul
Línea 41, columna 1:<window id="main-window"

just before the main browser window pops up.

Changed 12 months ago by gk

Attachment: bn-BD-linux.png added

comment:5 in reply to:  4 Changed 12 months ago by gk

Replying to gk:

The es-AR bundle is neither running on Linux nor on Windows I get

Error de análisis XML: entidad indefinida
Ubicación: chrome://browser/content/browser.xul
Línea 41, columna 1:<window id="main-window"

just before the main browser window pops up.

Okay, I fixed that. I did 4) not good enough ignoring the fact that es-AR strings needed to actually get added (not just updated) to the Torbutton repo. After that es-AR looks good to me.

comment:6 in reply to:  4 Changed 12 months ago by arthuredelstein

Replying to gk:

The bn-BD bundle seems to be missing a font or something as the title bar is just gibberish on Linux (see attachment).

Tor Browser does bundle Noto Sans Bengali, and is correctly rendering the bn-BD text in the rest of that window. The problem seems to be that GTK uses system fonts in the title bar but doesn't use our bundled fonts. So if a Bengali font is not installed on the system, then unicode tofu is displayed. (FWIW, I also see this on my Linux system with the zh-CN Tor Browser, because I don't have a Chinese font installed.)

To fix this in general we will need to investigate if it's possible to add the fonts bundled in Tor Browser to the GTK font search path.

comment:7 Changed 9 months ago by gk

For issues with bn-BD on Windows 10, see #29257.

comment:8 Changed 7 months ago by gk

Keywords: tbb-8.5 added

I think we can try getting es-AR into 8.5 (making sure we ship the next alpha with that locale enabled).

comment:9 Changed 7 months ago by gk

Keywords: TorBrowserTeam201903R GeorgKoppen201903R added
Status: needs_revisionneeds_review
Summary: Fix bn-BD and es-AR locale for Tor BrowserFix es-AR locale for Tor Browser

The patches for es-AR are up for review:

bug_26498 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_26498&id=970fa67ae56d959f94343010c2981d19b91fd189) in my tor-launcher repo,
bug_26498_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26498_v2&id=ab635bf6b1f77b00c24f03541150a2cf33cbdf3b) in my tor-browser-build repo, and
bug_26498 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_26498) in my torbutton repo. The latter has two commits, one to add es-AR (commit 2ef5a96194e5cb24aa756913322bec86055087bc) and then another one to update the translations to get the otherwise missing es-AR strings (commit b04b217a66dbc712ec928bbbdb927a3265080628).

I'll open a new ticket for bn-BD after we are done here.

comment:10 Changed 7 months ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed

Marking blockers for Tor Browser 8.5.

comment:11 Changed 7 months ago by gk

Keywords: tbb-8.5-must-alpha added; tbb-8.5-must removed

Tickets that block the next 8.5 alpha.

comment:12 Changed 7 months ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:13 Changed 7 months ago by gk

Keywords: GeorgKoppen201904 added

Moving my tickets for April

comment:14 Changed 7 months ago by mcs

r=brade, r=mcs
The patches look good to us.

comment:15 Changed 7 months ago by emmapeel

I have the perfect reviewer for this alpha, let me know and i'll ping them!

comment:16 in reply to:  14 Changed 7 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

r=brade, r=mcs
The patches look good to us.

Thanks. Merged to the respective master branches: torbutton (commit 3ff1320818bbe2b1dfce9cb8da50ee2a99b7dd9f), tor-launcher (commit 970fa67ae56d959f94343010c2981d19b91fd189), and tor-browser-build (commit c10e19ff904efd0bdb68ea40a83ac6cab49eb0dc).

comment:17 in reply to:  15 Changed 7 months ago by gk

Replying to emmapeel:

I have the perfect reviewer for this alpha, let me know and i'll ping them!

The nightlies starting from tomorrow and 8.5a11 will have those changes. Thus, looking over that woul dbe helpful.

comment:18 in reply to:  9 Changed 7 months ago by gk

Replying to gk:

[snip]

I'll open a new ticket for bn-BD after we are done here.

That's #30087.

Note: See TracTickets for help on using tickets.