Opened 2 years ago

Closed 2 years ago

#26502 closed defect (fixed)

Stop using the fallback blacklist, and delete it

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Fallback Scripts Version:
Severity: Normal Keywords: fallback, refactor, easy, python, 035-triaged-in-20180711
Cc: phoul Actual Points:
Parent ID: #24786 Points:
Reviewer: teor, phoul Sponsor:


We require relay operators to opt-in to being fallbacks, and we won't ever switch to opt-out. (See #24789.)

So we don't need the fallback blacklist any more.

We should stop loading the blacklist in the script, then delete it.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by teor

Cc: teor@… removed

Remove useless CC

comment:2 Changed 2 years ago by imnotbad

Status: newneeds_review

comment:3 Changed 2 years ago by teor

Cc: phoul added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Parent ID: #24786
Reviewer: teor, phoul

Hi phoul, would you mind running this branch to check that it works?
If it does, please flip this ticket to merge_ready.

Once we get rid of the blacklist, we only need to maintain one list (the whitelist).

comment:4 Changed 2 years ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:5 Changed 2 years ago by phoul

Status: needs_reviewmerge_ready

Have reviewed the pull request and the fallback script continues to behave as expected.

Setting to merge_ready.

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

ok; merged!

Note: See TracTickets for help on using tickets.