Opened 3 months ago

Closed 4 weeks ago

#26506 closed defect (fixed)

NoScript not working on TBB/ESR60 on Windows

Reported by: arthuredelstein Owned by: pospeselr
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201808, noscript
Cc: gk, mcs, brade, ezio, tbb-team, ma1 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

gk wrote:

One observation I had today while testing a Windows sv-SE bundle: it seems that NoScript is somehow not properly working as well? At least adjusting the security slider does not seem to work and I can't click on the NoScript icon. However, that might be worth a different bug as I have this issue with an en-US bundle, too. But on my Linux box it is working as expected.

Child Tickets

Change History (21)

comment:1 Changed 3 months ago by arthuredelstein

I can see clicking the NoScript button shows no doorhanger in our en-US bundle on Windows. I removed torbutton and the problem persists. Then I bisected noscript versions by installing different XPIs and I found:

  • dropdown fails: 10.1.5.8rc2 and later
  • dropdown appears: 10.1.5.8rc1 and earlier

We can diff these versions to figure out what changed. Might also be worth installing on Firefox 60ESR.

comment:2 Changed 3 months ago by arthuredelstein

(A feed of xpi versions with download links is at https://noscript.net/feed?t=a)

comment:3 Changed 3 months ago by arthuredelstein

I just found if I disable Tor Launcher, then the NoScript dropdown starts working again. (I ran a Tor instance by running another version of Tor Browser in the background.) If I enable Tor Launcher and disable Torbutton, then NoScript remains broken.

comment:4 Changed 3 months ago by arthuredelstein

Cc: gk mcs brade added

comment:5 in reply to:  1 Changed 3 months ago by cypherpunks

Replying to arthuredelstein:

I can see clicking the NoScript button shows no doorhanger in our en-US bundle on Windows. I removed torbutton and the problem persists. Then I bisected noscript versions by installing different XPIs and I found:

  • dropdown fails: 10.1.5.8rc2 and later
  • dropdown appears: 10.1.5.8rc1 and earlier

We can diff these versions to figure out what changed. Might also be worth installing on Firefox 60ESR.

https://github.com/avian2/noscript/commit/ef0e4bbf8591fc41f20ada7a6779336cf910aa39

comment:6 Changed 3 months ago by gk

Cc: ezio added

#26552 is a duplicate.

comment:7 Changed 3 months ago by boklm

A user reported that noscript is not working for them on Linux 64:
https://blog.torproject.org/comment/275993#comment-275993

I'm not sure if it's the same issue, or a different one for which we should open a new ticket.

comment:8 Changed 3 months ago by ma1

Please check latest development build, 10.1.8.3rc6 from https://noscript.net/getit#devel

comment:9 Changed 3 months ago by gk

Keywords: ff60-esr TorBrowserTeam201807 added
Priority: MediumVery High

comment:10 in reply to:  8 Changed 2 months ago by gk

Replying to ma1:

Please check latest development build, 10.1.8.3rc6 from https://noscript.net/getit#devel

Sorry for the long silence but the issue is still present in 10.1.8.8. Let me know if there are useful steps for debugging which I could do.

comment:11 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:12 Changed 5 weeks ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:13 Changed 5 weeks ago by boklm

Cc: tbb-team added

comment:14 Changed 5 weeks ago by gk

Cc: ma1 added

Griorgio: Can you help with this bug? That's pretty close to a release blocker for us and we need to start building in less than two weeks. Thanks!

comment:15 Changed 5 weeks ago by gk

Keywords: noscript added

comment:16 Changed 5 weeks ago by ma1

Did you check whether this is actually reproducible with latest RC (10.1.8.17rc7)?

comment:17 Changed 5 weeks ago by ezio

Hi, in my case (windows 7 sp1 64), after a few restarts noscript stop working, all the add-ons in the toolbar stop working as well (if i click on the noscript icon it doesn't open any menu and https everywhere shows a blank menu), i tested the Tor Browser 8.0a10r on http://ip-check.info/?lang=en and it clearly says that javascript is enabled and i can actually see all the informations.
Let me know if you need any further information

comment:18 Changed 5 weeks ago by ezio

the bug is still reproducible with ​latest RC (10.1.8.17rc7), i already tried

comment:19 Changed 5 weeks ago by ma1

I couldn't reproduce this at all, at least not in the original formulation of this bug (which did not imply the breakage happening after some usage and/or other extensions being broken too).

I had definitely fixed a bug producing exactly the effects described in the original post (and caused by a missing Firefox crypto API in the Tor Browser only) in 10.1.8.3rc6, with this commit.

Please close this and open a new bug for this new, intermittent and quite difficult to reproduce issue.
Also, please flag the NoScript Options>Advanced>Debug checkbox and attach whatever seems NoScript-related you can find in your browser console (ctrl+shift+J) just after the problem happens.

Thank you.

comment:20 Changed 5 weeks ago by ezio

hi, as requested i opened a new ticket https://trac.torproject.org/projects/tor/ticket/27269

comment:21 in reply to:  19 Changed 4 weeks ago by gk

Resolution: fixed
Status: assignedclosed

Replying to ma1:

I couldn't reproduce this at all, at least not in the original formulation of this bug (which did not imply the breakage happening after some usage and/or other extensions being broken too).

I had definitely fixed a bug producing exactly the effects described in the original post (and caused by a missing Firefox crypto API in the Tor Browser only) in 10.1.8.3rc6, with this commit.

Please close this and open a new bug for this new, intermittent and quite difficult to reproduce issue.
Also, please flag the NoScript Options>Advanced>Debug checkbox and attach whatever seems NoScript-related you can find in your browser console (ctrl+shift+J) just after the problem happens.

Thank you.

Alright, I just tested with 10.1.8.17 and our updated Torbutton and we are good here. I might have hit some caching issue back then in comment:10 (I still need to get used to the even more aggressive caching coming with esr60). For those that come to this bug: until we ship Torbutton 2.0.4 the symptoms will be similar with NoScript 10.1.8.17.

Note: See TracTickets for help on using tickets.