NoScript not working on TBB/ESR60 on Windows

gk wrote:

One observation I had today while testing a Windows sv-SE bundle: it seems that NoScript is somehow not properly working as well? At least adjusting the security slider does not seem to work and I can't click on the NoScript icon. However, that might be worth a different bug as I have this issue with an en-US bundle, too. But on my Linux box it is working as expected.

added TorBrowserTeam201808 component::applications/tor browser ff60-esr noscript owner::pospeselr priority::very high resolution::fixed severity::normal status::closed type::defect labels

I can see clicking the NoScript button shows no doorhanger in our en-US bundle on Windows. I removed torbutton and the problem persists. Then I bisected noscript versions by installing different XPIs and I found:

• dropdown fails: 10.1.5.8rc2 and later
• dropdown appears: 10.1.5.8rc1 and earlier

We can diff these versions to figure out what changed. Might also be worth installing on Firefox 60ESR.

(A feed of xpi versions with download links is at https://noscript.net/feed?t=a)

I just found if I disable Tor Launcher, then the NoScript dropdown starts working again. (I ran a Tor instance by running another version of Tor Browser in the background.) If I enable Tor Launcher and disable Torbutton, then NoScript remains broken.

Trac:
Cc: N/A to gk, mcs, brade

Replying to arthuredelstein:

I can see clicking the NoScript button shows no doorhanger in our en-US bundle on Windows. I removed torbutton and the problem persists. Then I bisected noscript versions by installing different XPIs and I found:

• dropdown fails: 10.1.5.8rc2 and later
• dropdown appears: 10.1.5.8rc1 and earlier

We can diff these versions to figure out what changed. Might also be worth installing on Firefox 60ESR. https://github.com/avian2/noscript/commit/ef0e4bbf8591fc41f20ada7a6779336cf910aa39

#26552 (moved) is a duplicate.

Trac:
Cc: gk, mcs, brade to gk, mcs, brade, ezio

A user reported that noscript is not working for them on Linux 64: https://blog.torproject.org/comment/275993#comment-275993

I'm not sure if it's the same issue, or a different one for which we should open a new ticket.

Please check latest development build, 10.1.8.3rc6 from https://noscript.net/getit#devel

Trac:
Priority: Medium to Very High
Keywords: N/A deleted, ff60-esr, TorBrowserTeam201807 added

Replying to ma1:

Please check latest development build, 10.1.8.3rc6 from https://noscript.net/getit#devel

Sorry for the long silence but the issue is still present in 10.1.8.8. Let me know if there are useful steps for debugging which I could do.

Move our tickets to August.

Trac:
Keywords: TorBrowserTeam201807 deleted, TorBrowserTeam201808 added

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Trac:
Cc: gk, mcs, brade, ezio to gk, mcs, brade, ezio, tbb-team

Griorgio: Can you help with this bug? That's pretty close to a release blocker for us and we need to start building in less than two weeks. Thanks!

Trac:
Cc: gk, mcs, brade, ezio, tbb-team to gk, mcs, brade, ezio, tbb-team, ma1

Trac:
Keywords: N/A deleted, noscript added

Did you check whether this is actually reproducible with latest RC (10.1.8.17rc7)?

Hi, in my case (windows 7 sp1 64), after a few restarts noscript stop working, all the add-ons in the toolbar stop working as well (if i click on the noscript icon it doesn't open any menu and https everywhere shows a blank menu), i tested the Tor Browser 8.0a10r on http://ip-check.info/?lang=en and it clearly says that javascript is enabled and i can actually see all the informations. Let me know if you need any further information

Trac:
Username: ezio

the bug is still reproducible with ​latest RC (10.1.8.17rc7), i already tried

Trac:
Username: ezio

I couldn't reproduce this at all, at least not in the original formulation of this bug (which did not imply the breakage happening after some usage and/or other extensions being broken too).

I had definitely fixed a bug producing exactly the effects described in the original post (and caused by a missing Firefox crypto API in the Tor Browser only) in 10.1.8.3rc6, with this commit.

Please close this and open a new bug for this new, intermittent and quite difficult to reproduce issue. Also, please flag the NoScript Options>Advanced>Debug checkbox and attach whatever seems NoScript-related you can find in your browser console (ctrl+shift+J) just after the problem happens.

Thank you.

hi, as requested i opened a new ticket https://trac.torproject.org/projects/tor/ticket/27269

Trac:
Username: ezio

Replying to ma1:

I couldn't reproduce this at all, at least not in the original formulation of this bug (which did not imply the breakage happening after some usage and/or other extensions being broken too).

I had definitely fixed a bug producing exactly the effects described in the original post (and caused by a missing Firefox crypto API in the Tor Browser only) in 10.1.8.3rc6, with this commit.

Please close this and open a new bug for this new, intermittent and quite difficult to reproduce issue. Also, please flag the NoScript Options>Advanced>Debug checkbox and attach whatever seems NoScript-related you can find in your browser console (ctrl+shift+J) just after the problem happens.

Thank you.

Alright, I just tested with 10.1.8.17 and our updated Torbutton and we are good here. I might have hit some caching issue back then in comment:10 (I still need to get used to the even more aggressive caching coming with esr60). For those that come to this bug: until we ship Torbutton 2.0.4 the symptoms will be similar with NoScript 10.1.8.17.

Trac:
Resolution: N/A to fixed
Status: assigned to closed

closed

mentioned in issue #26552 (moved)

mentioned in issue #27261 (moved)

moved to tpo/applications/tor-browser#26506 (closed)