Opened 11 months ago

Closed 11 months ago

Last modified 8 months ago

#26510 closed defect (implemented)

Make "bloomfilter set" code first-class

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactoring
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Our bloom filter duplicated between address_set.c and digestset.c, and it's slightly different in both cases. We should extract a common implementation type, use siphash, and name it bloomfilt_set or approx_set or somethign.

Child Tickets

Change History (3)

comment:1 Changed 11 months ago by nickm

I've done this in ticket26510, with a PR at https://github.com/torproject/tor/pull/183 . This ticket can become needs_review once the CI passes.

comment:2 Changed 11 months ago by dgoulet

Keywords: refactoring added
Reviewer: dgoulet
Status: assignedmerge_ready

ACK. If Travis is happy, I am.

comment:3 Changed 11 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.