Opened 3 weeks ago

Closed 10 days ago

Last modified 10 days ago

#26512 closed defect (implemented)

Rename various modules and headers from the src/common refactoring.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-roadmap-subtask
Cc: Actual Points:
Parent ID: #26481 Points:
Reviewer: dgoulet Sponsor: Sponsor3-can

Description

I'll use this ticket to track suggested renamings, and do them all at once.

So far I have:

util_malloc.[ch] -> malloc.[ch]
torlog.[ch] -> log.[ch]
crypt_ops -> ???
tm_cvt.[ch] -> tm_to_time.[ch]

Child Tickets

Change History (5)

comment:1 Changed 3 weeks ago by dgoulet

Maybe only this one? util_string.h -> string.h ?

Last edited 3 weeks ago by dgoulet (previous) (diff)

comment:2 Changed 2 weeks ago by nickm

Keywords: 035-roadmap-subtask added

comment:3 Changed 10 days ago by nickm

Status: assignedneeds_review

I have most of these done in a branch called "post-refactor-renaming"; PR at https://github.com/torproject/tor/pull/222

I'm slightly -1 on renaming util_string.h, since the "util" name distinguishies it from "compat_string.h".

I'd like to defer the crypto_ops renaming until we split it into smaller pieces.

comment:4 Changed 10 days ago by dgoulet

Cc: dgoulet removed
Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm and I'm fine with this.

comment:5 Changed 10 days ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.