Opened 9 months ago

Closed 8 months ago

#26518 closed defect (fixed)

The fourth most popular AS in the Tor network is "(distinct)"?

Reported by: arma Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords: metrics-geoip
Cc: Actual Points:
Parent ID: #26700 Points:
Reviewer: Sponsor:

Description

https://metrics.torproject.org/rs.html#aggregate/as
aims to give me a sorted list of which ASes are most represented in the Tor network.

The first is OVH, the second is Online SAS, the third is Hetzner, and the fourth most represented is... "(distinct)"? And when I click on it I just get this page again? What's going on there?

Child Tickets

Change History (6)

comment:1 Changed 9 months ago by nusenu

This is where onionoo does not provide any AS level data to Relay Search to aggregate on.

should #26585 get implemented this will no longer be a problem, until then
Relay Search should probably group all relays for which there is no AS level data into a fake AS
called "unknown AS" ?

comment:2 in reply to:  1 Changed 9 months ago by irl

Owner: changed from metrics-team to irl
Status: newaccepted

Replying to nusenu:

This is where onionoo does not provide any AS level data to Relay Search to aggregate on.

Indeed this is the case. It should be more obvious that this is happening though. There is meant to be a mapping to "Unknown" in this case. (Also for countries, there should be a mapping to "Unknown").

comment:3 Changed 9 months ago by irl

Keywords: metrics-geoip added

comment:4 Changed 9 months ago by irl

Status: acceptedmerge_ready

The issue was in that the placeholder "unknown" as was set to integer 0, but it should have been a string, so fixed to "AS0" in commit 6696615 in my relaysearch-dev branch.

As for being able to click and see those relays, see #26665.

comment:5 Changed 8 months ago by irl

Parent ID: #26700

comment:6 Changed 8 months ago by irl

Resolution: fixed
Status: merge_readyclosed

Merged in #26700.

Note: See TracTickets for help on using tickets.