Opened 3 weeks ago

Closed 2 weeks ago

#26523 closed defect (fixed)

HSPOST command doesn't parse HSADDRESS argument

Reported by: akwizgran Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.3-alpha
Severity: Normal Keywords: tor-hs, tor-control
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

The HSPOST command ignores the HSADDRESS argument unless a SERVER argument precedes it, and incorrectly parses the argument (the argument name and = sign are treated as part of the address).

The command returns a synchronous 250 OK response for v2 descriptors, but not for v3 descriptors.

Child Tickets

Attachments (1)

hspost.patch (1.7 KB) - added by akwizgran 3 weeks ago.
Patch against tor-0.3.4.3-alpha

Download all attachments as: .zip

Change History (4)

Changed 3 weeks ago by akwizgran

Attachment: hspost.patch added

Patch against tor-0.3.4.3-alpha

comment:1 Changed 3 weeks ago by teor

Milestone: Tor: 0.3.4.x-final
Status: newneeds_review

Thanks for this patch!

We should check if we need to backport it.

comment:2 Changed 3 weeks ago by dgoulet

Keywords: tor-hs tor-control added
Reviewer: dgoulet
Status: needs_reviewmerge_ready

Yes I think a backport would be needed since the HSPOST command is basically not working for HSv3.

The 033 branch: bug26523_033_01
Applies correctly to 034.

Thanks akwizgran!

comment:3 Changed 2 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

lgtm too; merged to 0.3.3 and forward.

Note: See TracTickets for help on using tickets.