Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#26526 closed defect (implemented)

Split all address.h functions that can invoke the resolver.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-roadmap-subtask
Cc: Actual Points:
Parent ID: #26481 Points:
Reviewer: dgoulet Sponsor:

Description

These should have consistent names, and either have their own header, or share resolve.h. Having them in the same place as functions that just do name parsing is not good practice.

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by nickm

Keywords: 035-roadmap-subtask added

comment:2 Changed 2 months ago by nickm

PR at https://github.com/torproject/tor/pull/221 , which covers both #26526 and #26532. Ticket is ticket26526_26532.

comment:3 Changed 2 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 2 months ago by nickm

Status: acceptedneeds_review

comment:5 Changed 2 months ago by dgoulet

Cc: dgoulet removed
Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm; CI still running...

comment:6 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

CI seems happy now; merging!

Note: See TracTickets for help on using tickets.