Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#26532 closed defect (implemented)

Combine ipv4.h and ipv6.h into address.h?

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-roadmap-subtask
Cc: Actual Points:
Parent ID: #26481 Points:
Reviewer: dgoulet Sponsor:

Description

Suggested during a review. I'm not sure about this; I could go either way.

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by teor

How often will a file include address.h without ipv4.h?
(address.h already includes ipv6.h.)

comment:2 Changed 3 months ago by nickm

Keywords: 035-roadmap-subtask added

comment:3 Changed 2 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 2 months ago by nickm

Status: acceptedneeds_review

PR at ​https://github.com/torproject/tor/pull/221 , which covers both #26526 and #26532. Ticket is ticket26526_26532.

comment:5 Changed 2 months ago by dgoulet

Cc: dgoulet removed
Reviewer: dgoulet
Status: needs_reviewmerge_ready

comment:6 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.