Opened 3 months ago

Closed 3 weeks ago

Last modified 3 weeks ago

#26561 closed defect (fixed)

Onion images are not displayed

Reported by: akrey Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201808R
Cc: pospeselr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When viewing http://expyuzz4wqqyqhjn.onion/images/icon-TorBrowser.jpg the image isn't displayed at all - the previous or empty page remains in the tab, but the context menu stops working.

This is only for onions; the corresponding https://www.torproject.org/images/icon-TorBrowser.jpg (with the centering restriction of #26544).

TBB 8.0a9, Windows7 64bit.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by cypherpunks

I can confirm (with Linux; 8.0a9 of course).

comment:2 Changed 5 weeks ago by sysrqb

Interesting. Loading this in 8.0a10, I see this over and over again. It continuously tries loading this resource and when it fails (with the below javascript error, it tries reloading it again.

[08-21 01:54:45] Torbutton INFO: controlPort >> 650 STREAM 20 SUCCEEDED 6 expyuzz4wqqyqhjn.onion:80
JavaScript error: chrome://global/content/browser-child.js, line 447: TypeError: req is null
[08-21 01:54:45] Torbutton INFO: tor SOCKS: http://expyuzz4wqqyqhjn.onion/images/icon-TorBrowser.jpg via
                       expyuzz4wqqyqhjn.onion:cd72a84c3bb37bdd021b0d3d82ab051a

For the non-onion connection, the image successfully loads but, again, it continuously refreshes and redownloads the image over and over again:

[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95

comment:3 Changed 4 weeks ago by arthuredelstein

I bisected and tracked this down to e05cdec593b6d088427584ce3107c1ab0a85b6d0, our patch for
"Bug #23247: Communicating security expectations for .onion"

comment:4 Changed 4 weeks ago by gk

Cc: pospeselr added
Keywords: TorBrowserTeam201808 added
Priority: MediumHigh

comment:5 Changed 4 weeks ago by arthuredelstein

The problem goes away if I revert e05cdec59's change to dom/security/nsMixedContentBlocker.cpp

comment:6 Changed 3 weeks ago by arthuredelstein

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: newneeds_review
Last edited 3 weeks ago by arthuredelstein (previous) (diff)

comment:7 Changed 3 weeks ago by gk

I think this looks good to me. Richard, could you have a second look? I think that's worth inclduing in 8.0 and essentially just code-moving in the .onion case.

comment:8 Changed 3 weeks ago by pospeselr

Patch looks good to me!

comment:9 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Cherry-picked to tor-browser-60.1.0esr-8.0-1 (commit 4f22857f926d1e35d22709a247cca0aa3f8e560f).

Last edited 3 weeks ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.