Onion images are not displayed

When viewing http://expyuzz4wqqyqhjn.onion/images/icon-TorBrowser.jpg the image isn't displayed at all - the previous or empty page remains in the tab, but the context menu stops working.

This is only for onions; the corresponding https://www.torproject.org/images/icon-TorBrowser.jpg (with the centering restriction of #26544 (moved)).

TBB 8.0a9, Windows7 64bit.

added TorBrowserTeam201808R component::applications/tor browser ff60-esr owner::tbb-team priority::high resolution::fixed severity::normal status::closed type::defect labels

I can confirm (with Linux; 8.0a9 of course).

Interesting. Loading this in 8.0a10, I see this over and over again. It continuously tries loading this resource and when it fails (with the below javascript error, it tries reloading it again.

[08-21 01:54:45] Torbutton INFO: controlPort >> 650 STREAM 20 SUCCEEDED 6 expyuzz4wqqyqhjn.onion:80
JavaScript error: chrome://global/content/browser-child.js, line 447: TypeError: req is null
[08-21 01:54:45] Torbutton INFO: tor SOCKS: http://expyuzz4wqqyqhjn.onion/images/icon-TorBrowser.jpg via
                       expyuzz4wqqyqhjn.onion:cd72a84c3bb37bdd021b0d3d82ab051a

For the non-onion connection, the image successfully loads but, again, it continuously refreshes and redownloads the image over and over again:

[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:07] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95
[08-21 01:58:08] Torbutton INFO: tor SOCKS: https://www.torproject.org/images/icon-TorBrowser.jpg via
                       torproject.org:d50525c6d67ac7cad3d8d820aac12d95

I bisected and tracked this down to e05cdec593b6d088427584ce3107c1ab0a85b6d0, our patch for "Bug #23247 (moved): Communicating security expectations for .onion"

Trac:
Priority: Medium to High
Cc: N/A to pospeselr
Keywords: N/A deleted, TorBrowserTeam201808 added

The problem goes away if I revert e05cdec59's change to dom/security/nsMixedContentBlocker.cpp

Here's a patch for review:

https://github.com/arthuredelstein/tor-browser/commit/23247

Trac:
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201808R added
Status: new to needs_review

I think this looks good to me. Richard, could you have a second look? I think that's worth inclduing in 8.0 and essentially just code-moving in the .onion case.

Patch looks good to me!

Thanks. Cherry-picked to tor-browser-60.1.0esr-8.0-1 (commit 4f22857f926d1e35d22709a247cca0aa3f8e560f).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #27395 (moved)

moved to tpo/applications/tor-browser#26561 (closed)

mentioned in issue tpo/applications/tor-browser#27395 (closed)