#26566 closed defect (fixed)

check.torproject.org doesn't recognise tbb-alpha

Reported by: tgragnato Owned by: arlolra
Priority: Medium Milestone:
Component: Applications/Tor Check Version:
Severity: Normal Keywords:
Cc: adrelanos@…, gamma@…, sysrqb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


check.torproject.org doesn't recognise the latest esr60-based alpha (8.0a9) as a legit tor browser bundle.

Congratulations. This browser is configured to use Tor.
However, it does not appear to be Tor Browser.
Click here to go to the download page

Child Tickets

#26577closedarlolracheck.tp.o thinks Tor Browser 8.x user agent isn't Tor BrowserApplications/Tor Check

Change History (10)

comment:1 Changed 18 months ago by teor

Component: Webpages/WebtoolsApplications/Tor Check
Owner: changed from hiro to arlolra

comment:2 Changed 18 months ago by boklm

#26577 is a duplicate.

comment:3 Changed 18 months ago by adrelanos

Cc: adrelanos@… added

comment:4 Changed 18 months ago by cypherpunks

Cc: gamma@… added

comment:5 Changed 18 months ago by arma

Cc: sysrqb added

Cc'ing Matt since he was the author of the last patch to update the expected user agent.

comment:6 Changed 18 months ago by arma

If the Tor Browser folks can say here what the right user agents are, then we'll be closer to fixing this bug.

Unless the right fix is to abandon the "check user agent to see if it's really tor browser" feature in Check, now that there will be many user agents? (Seems like we want to keep it if we can, especially with the new browsers that are integrating with Tor.)

comment:7 Changed 18 months ago by arlolra

Presumably, it's rv:60.0. I can deploy this on Monday unless you feel there's some urgency to it?

comment:8 Changed 18 months ago by arma

Monday should be just fine. Thanks!

(I keep messing with the ticket because users keep reporting it as an issue, since the browser team asked people to try the new tor browser beta.)

And, I hear from the browser team that they're changing up the user agent thing, maybe to stop claiming that everything is Windows, since it's breaking some behavior and the lie isn't very convincing. Plus there's Tor Browser Android coming. ...I'll let the browser folks provide actual facts rather than just my rumors. :)

comment:9 in reply to:  6 Changed 18 months ago by cypherpunks

@arma please see comments on #26146 and https://blog.torproject.org/new-release-tor-browser-80a9#comments for that issue, let's keep different issues separate.

comment:10 Changed 18 months ago by arlolra

Resolution: fixed
Status: newclosed

I made it more permissive in https://gitweb.torproject.org/check.git/commit/?id=c6a82190f970a6598541d1fbd1422c9ef16fc4fe

And I'll keep an eye out for a decision in #26146 in case that can be reverted.

It's now deployed.

Note: See TracTickets for help on using tickets.