--ControlPortWriteToFile reports port 0 on --ControlPort=auto, not opened port

If I start the latest tor code with --ControlPort=auto and --ControlPortWriteToFile=/path/to/file, then the contents of the file end up as PORT=127.0.0.1:0, which is kind of useless :)

I guess some code got messed up lately that updates the port before writing it out to the control file.

Trac:
Username: karalabe

changed milestone to %Tor: 0.3.4.x-final

added 034-must auto component::core tor/tor control empty invalid milestone::Tor: 0.3.4.x-final owner::nickm port priority::medium regression reporter::karalabe resolution::fixed reviewer::dgoulet severity::major status::closed type::defect version::tor unspecified labels

Hi, thanks for this bug report. Which branch and commit are you using?

Questions for the developers: Are we writing the file before we assign and open the control port? Or did we change one of the control port functions in the refactor?

Trac:
Keywords: N/A deleted, regression? added
Milestone: N/A to Tor: 0.3.5.x-final
Version: N/A to Tor: unspecified

What was the last version that worked? Does this issue happen with Tor 0.3.3 or Tor 0.3.4?

I have a fairly funky build setup, I pulled latest master where this issue was happening (not sure when it started, just started using Tor now). If I revert to latest stable (0.3.3.7), then everything works fine. Didn't test 0.3.4 as it conflicts with my builder.

Trac:
Username: karalabe

I can confirm that 0.3.4 has this problem too, and 0.3.3 does not.

Trac:
Keywords: regression? deleted, regression added
Milestone: Tor: 0.3.5.x-final to Tor: 0.3.4.x-final

Git bisect tells me that 6ed384b827dce21ea3a44b58792cc28b2ed48056 was the first bad commit.

I think removing the gotPort field here was wrong.

Trac:
Keywords: N/A deleted, 034-must added
Status: new to accepted
Owner: N/A to nickm

See branch bug26568_034 and PR at https://github.com/torproject/tor/pull/201

Trac:
Status: accepted to needs_review

working. lgtm;

Trac:
Status: needs_review to merge_ready
Reviewer: N/A to dgoulet

Merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#26568 (closed)