Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2660 closed defect (fixed)

get_interface_address6() fixes

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

piebeer noticed some problems with get_interface_address6() and provided a patch:

connect's third argument should be dependent on address family, otherwise connect might return einval. This apparently happened in #599 and #1141 too.

While looking at that, I noticed another issue:

the port is not set correctly for both families. Danieldg provided review and assistance for this too.

Child Tickets

Change History (6)

comment:1 Changed 9 years ago by Sebastian

Status: newneeds_review

Patch in branch bug2660 in my repo

comment:2 Changed 9 years ago by Sebastian

Milestone: Tor: 0.2.2.x-final

comment:3 Changed 9 years ago by Sebastian

pushed an update to correct the bugfix-on line.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks good; merging.

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.