#26626 closed defect (implemented)

Require stdint and inttypes; remove most (but not all) of torint.h; use standard PRIuXX macros

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactoring
Cc: Actual Points:
Parent ID: #26481 Points:
Reviewer: dgoulet Sponsor:

Description

We've been requiring stdint.h for a while now -- trunnel headers all use it, and so does some of the hs_*.c code.

Let's assume that we have the standard c99 headers, and use their definitions of the stuff that they define. It isn't 2003 any more :)

Child Tickets

Change History (4)

comment:1 Changed 15 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 15 months ago by nickm

Status: acceptedneeds_review

See branch ticket26626, with PR at https://github.com/torproject/tor/pull/207 . Please ignore the early commits in that branch, which are already in master -- the automated update on the github repo seems to be under maintenance.

comment:3 Changed 15 months ago by dgoulet

Cc: dgoulet removed
Keywords: refactoring added
Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

This overall look ok. I think once merged some more crazier platform might scream or/and compilers which we can fix right then.

comment:4 Changed 15 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

ok; merging!

Note: See TracTickets for help on using tickets.