Opened 3 months ago

Closed 2 months ago

Last modified 6 weeks ago

#26647 closed defect (implemented)

defect: Spec for net/listeners/* doesn't covers HTTPTunnelPort directive or ExtORPort

Reported by: pyhedgehog Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-spec, controller, easy, intro, fast-fix, 032-backport, 033-backport, 034-backport, 035-triaged-in-20180711, tor-httptunnel
Cc: Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:

Description (last modified by teor)

There are (rather) new type of listener, that's not covered by 'GETINFO net/listeners/*'.

Child Tickets

Change History (11)

comment:1 Changed 3 months ago by teor

Description: modified (diff)
Keywords: easy intro added
Milestone: Tor: unspecified

Fix a typo and tag

comment:2 Changed 3 months ago by nickm

Keywords: fast-fix added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Owner: set to nickm
Status: newaccepted

comment:3 Changed 3 months ago by nickm

Summary: defect: Spec for net/listeners/* doesn't covers HTTPTunnelPort directivedefect: Spec for net/listeners/* doesn't covers HTTPTunnelPort directive or ExtORPort

comment:4 Changed 3 months ago by nickm

Keywords: 032-backport 033-backport 034-backport added

comment:5 Changed 3 months ago by nickm

Status: acceptedneeds_review

See branch ticket26647_032 in my public repo; it is a trivial fix. I also added ExtORPort support, since that was also missing.

See also branch ticket26647 in my public torspec repo, which documents this change.

I'm proposing we backport this as far as 0.3.2.x, which is the earliest supported release with HTTPTunnelPort. If somebody wants, we can also backport the ExtORPort part to 0.2.9, but since nobody has ever wanted it, I'm guessing a backport of that is not super important. :)

comment:6 Changed 3 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:7 Changed 2 months ago by asn

Reviewer: teor

comment:8 Changed 2 months ago by pyhedgehog

Should also find it's way to docs and stem.

comment:9 in reply to:  8 Changed 2 months ago by teor

Status: needs_reviewneeds_revision

Replying to pyhedgehog:

Should also find it's way to docs and stem.

ticket26647 patches control-spec.txt, which is the documentation for the Tor control protocol. Stem usually follows torspec updates pretty closely.

Here's my review:

tor/ticket26647 is a nice simple change that seems fine. Let's merge it.

torspec/ticket26647 needs revision, because we did some tor releases since the patch. Then we can merge it.

comment:10 Changed 2 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.2.x-final
Resolution: implemented
Status: needs_revisionclosed

Updated and merged the spec branch; merged the tor branch to 0.3.2 and forward.

comment:11 Changed 6 weeks ago by traumschule

Keywords: tor-httptunnel added
Note: See TracTickets for help on using tickets.