Update d3dcompiler_47.dll to latest version in Tor Browser (10.0.15063.675)

A user on the blog (https://blog.torproject.org/comment/275958#comment-275958) mentioned there is a newer version of the d3dcompiler_47 library we ship with Tor Browser and strongly suggested to update the one we provide.

added component::applications/tor browser ff60-esr owner::tbb-team priority::medium severity::normal status::needs-information type::defect labels

Right now, we ship version 10.0.15063.674. I wonder how Mozilla keeps track of that and decides when to update the dlls they ship. Tom, any insights into that?

Trac:
Status: new to needs_information

We copy it out of the Windows SDK I believe, so it'd get updated if there's a new version when we bump SDKs.

Replying to tom:

We copy it out of the Windows SDK I believe, so it'd get updated if there's a new version when we bump SDKs.

Hm, okay. I guess Mozilla is confident enough that enough testing on Nightlies etc. makes sure that ESR is not breaking and thus, updating on the ESR branch is okay, too.

Replying to gk:

Replying to tom:

We copy it out of the Windows SDK I believe, so it'd get updated if there's a new version when we bump SDKs.

Hm, okay. I guess Mozilla is confident enough that enough testing on Nightlies etc. makes sure that ESR is not breaking and thus, updating on the ESR branch is okay, too.

Well, for ESR we wouldn't update the SDK actually, we'd keep the current version unless there was a need to bump it.

Replying to gk: Hint: you no longer need to ship Microsoft libraries ;)

Trac:
Username: ge

Replying to ge:

Replying to gk: Hint: you no longer need to ship Microsoft libraries ;)

How so? What did suddenly change?

Replying to gk:

Replying to ge:

Replying to gk: Hint: you no longer need to ship Microsoft libraries ;)

How so? What did suddenly change? :) min reqs ;) - up-to-date Win 7+

Trac:
Username: ge

Long story short: due to Microsoft stupidity, they had to add the needed libraries as Windows components via Windows Update to all Win 7+ distributions.

Trac:
Username: ge

Replying to ge:

Long story short: due to Microsoft stupidity, they had to add the needed libraries as Windows components via Windows Update to all Win 7+ distributions.

Do you have a link explaining what happened?

Replying to gk:

Replying to ge:

Long story short: due to Microsoft stupidity, they had to add the needed libraries as Windows components via Windows Update to all Win 7+ distributions.

Do you have a link explaining what happened? :) Poor gk doesn't want to use DDG :) From the first page for d3dcompiler_47.dll: was - http://www.tomshardware.co.uk/answers/id-3448565/d3dcompiler-dll-missing-fix.html, now - https://support.microsoft.com/en-us/help/4019990/update-for-the-d3dcompiler-47-dll-component-on-windows You can also search for the cumulative update of Windows 7 which silently adds msvcr100.dll to Windows components, but it's not good to use that dll at all, due to https://www.experts-exchange.com/questions/28935394/how-to-get-msvcr100-dll-version-10-0-40219-332-for-windows7.html and no support for #12968 (moved) (and many other reasons). FWIW, UCRT was added to Windows 7+ components in https://support.microsoft.com/en-us/help/2999226/update-for-universal-c-runtime-in-windows

Trac:
Username: ge

The most hilarious thing is that Firefox (e.g. 61.0.2) loads d3dcompiler_47.dll from C:\Windows\System32 ;)

Trac:
Username: ge

Just a gentle reminder to stop bundling d3dcompiler_47.dll (~4MB, FWIW, #26204 (moved)) and also try "Wine D3DCompiler" for #25837 (moved) (fxc2 doesn't use it, but uses "Wine UCRT" and "produces similar (but not exactly the same) output as fxc" which is a good point for fingerprinting investigation and Wine vs. MS comparison). There should be a ticket for switching to pure open-source toolchain, right? (And for upstreaming fxc2 to Wine or MinGW-w64?)

moved to tpo/applications/tor-browser-build#26650 (closed)