Opened 3 months ago

Closed 2 months ago

#26663 closed defect (implemented)

Make torrc "auto" values case insensitive?

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

We had a relay operator who tried to do

ORPort Auto

but it failed, because it doesn't know what the "Auto" argument means. Now, the "auto" argument works just fine.

It seems like an easy step to be flexible about the case here. Are there any reasons not to?

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by teor

We could make all the flags case-insensitive. But maybe that belongs in another ticket.

comment:2 Changed 3 months ago by nickm

Milestone: Tor: unspecified

I'd take a patch for this; the way to do it is to change the functions in config.c and confparse.c that parse these types. Look for the string "auto".

comment:3 Changed 3 months ago by asn

Status: newneeds_review

Patch by Xair here: https://github.com/torproject/tor/pull/213

(posting for xair because of the new trac restrictions)

comment:4 Changed 3 months ago by asn

Reviewer: asn

comment:5 Changed 2 months ago by asn

Status: needs_reviewmerge_ready

LGTM! Thanks for writing tests too!

comment:6 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Looks good to me; merged!

Note: See TracTickets for help on using tickets.