Opened 3 months ago

Closed 3 months ago

#26665 closed enhancement (fixed)

Allow searching for relays with no known AS/country

Reported by: irl Owned by: irl
Priority: Medium Milestone: Onionoo 1.15.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: karsten Sponsor:

Description

Currently it is not possible to drill down on the aggregated view in relay search into the "Unknown" AS or country.

Relay Search uses xz as the unknown country code, and AS0 as the unknown autonomous system.

It would not be needed to return these in the details documents, but only to build indexes with these values.

Child Tickets

Change History (10)

comment:1 Changed 3 months ago by karsten

Sounds like a fine plan! Do you want to write a patch? If not, I can probably do it next week.

comment:2 Changed 3 months ago by irl

Owner: changed from metrics-team to irl
Status: newaccepted

I can make a patch this week.

comment:3 Changed 3 months ago by irl

Status: acceptedneeds_review

Small patch for spec: https://gitweb.torproject.org/user/irl/metrics-web.git/log/?h=task/26665

Changes for Onionoo: https://github.com/irl/onionoo/pull/2

Actually quite a small change.

comment:4 Changed 3 months ago by irl

I also now have a git.tpo repository, so the changes for Onionoo are also pushed to my task/26665 branch there.

comment:5 Changed 3 months ago by karsten

Cc: metrics-team added
Reviewer: karsten

I'll take a look now. (I didn't receive an email from Trac about your latest updates. Please make sure to always copy metrics-team on tickets.)

comment:6 Changed 3 months ago by karsten

Status: needs_reviewmerge_ready

Merged the Onionoo patch to master! Thanks!

The metrics-web patch should also contain an update to the protocol versions list. This change can go into the next minor version together with other changes, but it should be mentioned there, because it changes (extends) behavior of existing parameters. Also, the two updated parameters should contain a brief sentence saying when they have been updated. All of this can happen when we put out the next release. But let's leave this ticket open until then.

comment:7 Changed 3 months ago by irl

Ah ok. The reason I did not add a change in the version list was because I knew there was already an unmerged change in the previous patch, and I was wondering how you were going to resolve the merge conflict. Should I just always make the changes as if it's a new version in the list and then you merge the changes when we do the actual merge to metrics-web?

comment:8 Changed 3 months ago by karsten

Good question. I'd say just pretend there's no other branch and let me handle the conflicts. Alternatively, if you prefer, you could base your patch off that other branch. Up to you. Thanks for asking!

comment:9 Changed 3 months ago by karsten

Milestone: Onionoo 1.15.0

comment:10 Changed 3 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Closing, because Onionoo 6.1-1.15.0 is now released.

Note: See TracTickets for help on using tickets.