Integrate Tor Browser for Android into tor-browser-build

The Tor Browser Hacking Guide has some instructions for manually building Orfox: https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking#BuildingOrfox

We need to integrate the build of Orfox and all components of Tor Browser for Android into tor-browser-build.

added TBA-a2 TorBrowserTeam201811 component::applications/tor browser owner::tbb-team parent::5709 priority::very high resolution::fixed severity::normal sponsor::8 status::closed tbb-mobile tbb-rbm type::task labels

Trac:
Parent: N/A to #5709 (moved)

Bumping prio.

Trac:
Priority: Medium to High

Move our tickets to August.

Trac:
Keywords: TorBrowserTeam201807 deleted, TorBrowserTeam201808 added

FWIW: One thing which should be kept in mind as well is that the build process must not download random things and it them. I.e. the build itself is supposed to succeed without any network access. I mention this here because I found such network activity while looking at my build log:

24:36.86 /var/tmp/build/firefox-9c58e200f6eb/mach android assemble-app
24:37.33  0:00.31 /var/tmp/build/firefox-9c58e200f6eb/gradlew --console=plain geckoview:generateJNIWrappersForGeneratedOfficialWithGeckoBinariesNoMinApiRelease app:generateJNIWrappersForFennecOfficialWithoutGeckoBinariesNoMinApiPhotonDebug app:assembleOfficialWithoutGeckoBinariesNoMinApiPhotonDebug app:assembleOfficialWithoutGeckoBinariesNoMinApiPhotonDebugAndroidTest -x lint --continue
24:37.46 Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
24:37.74 Downloading https://services.gradle.org/distributions/gradle-4.1-all.zip

I did a quick count of gradle dependencies (jars + poms). We are looking at 960 downloads we will need to handle.

Replying to sisbell:

I did a quick count of gradle dependencies (jars + poms). We are looking at 960 downloads we will need to handle.

How do they handle this in the firefox repository? Do they have a list of dependencies somewhere?

Replying to boklm:

Replying to sisbell:

I did a quick count of gradle dependencies (jars + poms). We are looking at 960 downloads we will need to handle.

How do they handle this in the firefox repository? Do they have a list of dependencies somewhere?

They are using the sdkmanager which contains the direct dependencies (there are also transitive dependencies downloaded through the gradle process). I have a final count of 186 artifacts to download (after deduping). We can do this through RBM but it will be a little ugly as we need to download and then copy all artifacts to correct folder structure under a repo directory.

In build/docs/toolchains.rst they describe how they generate an archive containing the dependencies: https://dxr.mozilla.org/mozilla-central/source/build/docs/toolchains.rst

However the process for creating this archive does not look very simple.

It also says "Gradle and the downloaded Maven dependencies can be both redistributed publicly" so I'm wondering if we could get a copy of that archive to use it.

Moving our tickets to September 2018

Trac:
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201809 added

Moving tickets to October

Trac:
Keywords: TorBrowserTeam201809 deleted, TorBrowserTeam201810 added

Trac:
Sponsor: N/A to Sponsor8

Moving our tickets to November.

Trac:
Keywords: TorBrowserTeam201810 deleted, TorBrowserTeam201811 added

Trac:
Priority: High to Very High
Keywords: N/A deleted, TBA-a2 added

We are done here! Thanks everyone!

Trac:
Status: new to closed
Resolution: N/A to fixed

closed

mentioned in issue #26974 (moved)

mentioned in issue #26975 (moved)

mentioned in issue #26976 (moved)

mentioned in issue #26977 (moved)

moved to tpo/applications/tor-browser#26693 (closed)