Opened 14 months ago

Closed 5 months ago

#26694 closed enhancement (fixed)

dir-spec: DirAuths should expose bwauth bandwidth files

Reported by: juga Owned by: juga
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, metrics, tor-bwauth, 035-triaged-in-20180711, torspec
Cc: Actual Points:
Parent ID: #21377 Points:
Reviewer: juga, teor Sponsor:

Description

This ticket is for changing dir-spec to implement #21377

Child Tickets

Change History (18)

comment:1 Changed 14 months ago by teor

Status: assignedneeds_revision

The pull request https://github.com/torproject/torspec/pull/21 is in needs_revision.

Let's deal with it in this ticket.

comment:2 Changed 14 months ago by juga

Status: needs_revisionneeds_review

comment:3 Changed 14 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:4 Changed 13 months ago by teor

Cc: teor removed
Reviewer: juga, teor

Hi juga,

I made some edits to the spec.
Please see my branch ticket21377 at https://github.com/teor2345/torspec.git
My pull request is available at ​https://github.com/torproject/torspec/pull/26

Or you can push my commits to your ​https://github.com/torproject/torspec/pull/21
Please see my comments on ​https://github.com/torproject/torspec/pull/21

If you're happy with it, let's merge my branch ticket21377-squashed.

comment:5 Changed 13 months ago by juga

PR 26 lgtm, yes, let's merge squashed branch.

comment:6 Changed 13 months ago by teor

Status: needs_reviewmerge_ready

Please assign a proposal number to proposals/xxx-expose-bandwidth-files.txt, then merge my torspec branch ticket21377-squashed from https://github.com/teor2345/torspec.git

I emailed the proposal to tor-dev:
https://lists.torproject.org/pipermail/tor-dev/2018-July/013322.html

comment:7 Changed 13 months ago by nickm

It's now prop296.

comment:8 Changed 13 months ago by teor

Resolution: fixed
Status: merge_readyclosed

The spec has been merged to torspec and dir-spec, we'll continue the implementation in #21377.

comment:9 Changed 10 months ago by teor

Resolution: fixed
Status: closedreopened

This spec needs an update, because the feature did not make it into 0.3.5:
https://github.com/torproject/torspec/blob/master/dir-spec.txt#L2640

comment:10 Changed 9 months ago by juga

It first appeared in tor-0.3.5.1-alpha, should it be changed to that?, or should we wait until it make it into a release and put that instead?

comment:11 in reply to:  10 Changed 9 months ago by teor

Replying to juga:

It first appeared in tor-0.3.5.1-alpha, should it be changed to that?

Which feature first appeared in tor-0.3.5.1-alpha?

Tor 0.3.5.1-alpha has been released. But the code for "DirAuths should expose bwauth bandwidth files" is in #21377. And it has not been merged yet.

or should we wait until it make it into a release and put that instead?

We should wait until #21377 is merged, then update the spec.

comment:12 Changed 7 months ago by teor

When #21377 is merged, we should update the spec to say that these features are in 0.4.1.1-alpha and later.

comment:13 Changed 7 months ago by juga

Keywords: torspec added
Milestone: Tor: 0.3.5.x-finalTor: 0.4.1.x-final

Since the parent (implementation) is now in 0.4.1.x-final milestone and we want to wait for the implementation to be merged before updating this spec, changing milestone also for the spec.

comment:14 Changed 5 months ago by juga

So, afaiu, #21377 has now been merged in 0.4.0 but the ticket is not closed be we're waiting for a dirauth to actually test it (and merge in 0.3.5 and 0.3.4)?

Should we still wait until those merges to update the version in the spec and close this ticket?

comment:15 Changed 5 months ago by teor

We should update the spec now, because it is wrong.

The standard URLs for bandwidth list files first-appeared in Tor 0.4.0.4-alpha.

If we decide to backport to 0.3.5, we can update the spec again.

comment:16 Changed 5 months ago by juga

Status: reopenedneeds_review

comment:17 Changed 5 months ago by teor

Status: needs_reviewmerge_ready

Looks good, I will merge the fix later today.

comment:18 Changed 5 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to master!
Thanks for your hard work!

Note: See TracTickets for help on using tickets.