dir-spec: DirAuths should expose bwauth bandwidth files

This ticket is for changing dir-spec to implement #21377 (moved)

changed milestone to %Tor: 0.4.1.x-final

added 035-triaged-in-20180711 component::core tor/tor metrics milestone::Tor: 0.4.1.x-final owner::juga parent::21377 priority::medium resolution::fixed reviewer::juga reviewer::teor severity::normal status::closed tor-bwauth tor-dirauth torspec type::enhancement labels

The pull request https://github.com/torproject/torspec/pull/21 is in needs_revision.

Let's deal with it in this ticket.

Trac:
Status: assigned to needs_revision

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: tor-dirauth metrics tor-bwauth deleted, tor-dirauth, tor-bwauth, 035-triaged-in-20180711, metrics added

Hi juga,

I made some edits to the spec. Please see my branch ticket21377 at https://github.com/teor2345/torspec.git My pull request is available at ​https://github.com/torproject/torspec/pull/26

Or you can push my commits to your ​https://github.com/torproject/torspec/pull/21 Please see my comments on ​https://github.com/torproject/torspec/pull/21

If you're happy with it, let's merge my branch ticket21377-squashed.

Trac:
Reviewer: N/A to juga, teor
Cc: teor to N/A

PR 26 lgtm, yes, let's merge squashed branch.

Please assign a proposal number to proposals/xxx-expose-bandwidth-files.txt, then merge my torspec branch ticket21377-squashed from https://github.com/teor2345/torspec.git

I emailed the proposal to tor-dev: https://lists.torproject.org/pipermail/tor-dev/2018-July/013322.html

Trac:
Status: needs_review to merge_ready

It's now prop296.

The spec has been merged to torspec and dir-spec, we'll continue the implementation in #21377 (moved).

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

This spec needs an update, because the feature did not make it into 0.3.5: https://github.com/torproject/torspec/blob/master/dir-spec.txt#L2640

Trac:
Status: closed to reopened
Resolution: fixed to N/A

It first appeared in tor-0.3.5.1-alpha, should it be changed to that?, or should we wait until it make it into a release and put that instead?

Replying to juga:

It first appeared in tor-0.3.5.1-alpha, should it be changed to that?

Which feature first appeared in tor-0.3.5.1-alpha?

Tor 0.3.5.1-alpha has been released. But the code for "DirAuths should expose bwauth bandwidth files" is in #21377 (moved). And it has not been merged yet.

or should we wait until it make it into a release and put that instead?

We should wait until #21377 (moved) is merged, then update the spec.

When #21377 (moved) is merged, we should update the spec to say that these features are in 0.4.1.1-alpha and later.

Since the parent (implementation) is now in 0.4.1.x-final milestone and we want to wait for the implementation to be merged before updating this spec, changing milestone also for the spec.

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.4.1.x-final
Keywords: N/A deleted, torspec added

So, afaiu, #21377 (moved) has now been merged in 0.4.0 but the ticket is not closed be we're waiting for a dirauth to actually test it (and merge in 0.3.5 and 0.3.4)?

Should we still wait until those merges to update the version in the spec and close this ticket?

We should update the spec now, because it is wrong.

The standard URLs for bandwidth list files first-appeared in Tor 0.4.0.4-alpha.

If we decide to backport to 0.3.5, we can update the spec again.

At least, easy fix: https://github.com/torproject/torspec/pull/70

Trac:
Status: reopened to needs_review

Looks good, I will merge the fix later today.

Trac:
Status: needs_review to merge_ready

Merged to master! Thanks for your hard work!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed