Opened 3 months ago

Last modified 3 weeks ago

#26696 needs_revision task

Add definition for new platform in rbm.conf

Reported by: boklm Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TorBrowserTeam201809
Cc: sisbell Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor:

Description

In order to be able to integrate Tor Browser for Android into tor-browser-build, we need to add a definition for the new platform into rbm.conf.

To do that we need to decide:

  • which OS we want to use inside the build containers. Probably Debian Stable, unless we have a reason for using something else.
  • how we want to name this new tor browser platform in tor-browser-build/rbm.conf. Currently we have: linux-x86_64, linux-i686, windows-i686, windows-x86_64 and osx-x86_64.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by gk

Priority: MediumHigh

Bumping prio.

comment:2 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:4 Changed 3 weeks ago by boklm

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808 removed
Status: newneeds_review

comment:5 in reply to:  3 Changed 3 weeks ago by boklm

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201809R removed
Status: needs_reviewneeds_revision

Replying to sisbell:

commit: https://github.com/sisbell/tor-browser-build/commit/f0f57154e87ec271d90fd6b82ba2d12e0ae0f468

Some first comments about this commit:

  • targets should be named torbrowser-android-armv7 and android-armv7, as we might add support for other android architectures later.
  • var/osname should be android-armv7.
  • var/compiler should be set to android-toolchain instead of gcc.
  • snowflake and fteproxy should be set to 0 as I don't think they can be built for android yet.

comment:6 Changed 3 weeks ago by boklm

The line changing the runc version spec line does not seem to be related to the android build. So it should be done in a separate commit/ticket.

Note: See TracTickets for help on using tickets.