Opened 4 months ago

Closed 4 weeks ago

#26696 closed task (fixed)

Add definition for new platform in rbm.conf

Reported by: boklm Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TorBrowserTeam201810R
Cc: sisbell Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor:

Description

In order to be able to integrate Tor Browser for Android into tor-browser-build, we need to add a definition for the new platform into rbm.conf.

To do that we need to decide:

  • which OS we want to use inside the build containers. Probably Debian Stable, unless we have a reason for using something else.
  • how we want to name this new tor browser platform in tor-browser-build/rbm.conf. Currently we have: linux-x86_64, linux-i686, windows-i686, windows-x86_64 and osx-x86_64.

Child Tickets

Change History (15)

comment:1 Changed 4 months ago by gk

Priority: MediumHigh

Bumping prio.

comment:2 Changed 4 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:4 Changed 2 months ago by boklm

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808 removed
Status: newneeds_review

comment:5 in reply to:  3 Changed 2 months ago by boklm

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201809R removed
Status: needs_reviewneeds_revision

Replying to sisbell:

commit: https://github.com/sisbell/tor-browser-build/commit/f0f57154e87ec271d90fd6b82ba2d12e0ae0f468

Some first comments about this commit:

  • targets should be named torbrowser-android-armv7 and android-armv7, as we might add support for other android architectures later.
  • var/osname should be android-armv7.
  • var/compiler should be set to android-toolchain instead of gcc.
  • snowflake and fteproxy should be set to 0 as I don't think they can be built for android yet.

comment:6 Changed 2 months ago by boklm

The line changing the runc version spec line does not seem to be related to the android build. So it should be done in a separate commit/ticket.

comment:7 Changed 8 weeks ago by sisbell

I fixed these issues. Also broke out the run version spec into separate commit (this commit is already on master build)

comment:8 Changed 8 weeks ago by sisbell

The commits can be found at

https://github.com/sisbell/tor-browser-build/commits/android-rebased

comment:9 in reply to:  7 Changed 7 weeks ago by boklm

Replying to sisbell:

I fixed these issues. Also broke out the run version spec into separate commit (this commit is already on master build)

This should be rebased on master, so we don't need to include this runc spec patch.

comment:10 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201810 added; TorBrowserTeam201809 removed

Moving tickets to October

comment:11 Changed 6 weeks ago by boklm

Commit 4abb076a83ff509125fe75bcd3d17ad51181c5a2 looks like a good start. I think we can merge it after #27441, and update the definition in following commits if needed.

Note: creating a new branch for new revisions of the patches (instead of force pushing on the same branch) would make it easier to see what changed.

comment:12 Changed 5 weeks ago by gk

sisbell: could you remove the trailing whitespaces here as well, please?

comment:13 Changed 4 weeks ago by sisbell

Removed trailing white spaces from rbm.conf:  https://github.com/sisbell/tor-browser-build/commits/android-1017

comment:14 Changed 4 weeks ago by boklm

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201810 removed
Status: needs_revisionneeds_review

Commit 483f8fc5880aeb8b42695fe5008e29c230b86994 looks good to me. I think we can merge it after #27441.

comment:15 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master (commit 51aae94ab13e575ddbcba0cff4dbb9c69c4a612e), thanks!

Note: See TracTickets for help on using tickets.