Opened 3 months ago

Last modified 3 weeks ago

#26697 needs_revision task

Add Android toolchain

Reported by: boklm Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, tbb-mobile, TorBrowserTeam201809
Cc: sisbell Actual Points:
Parent ID: #26693 Points:
Reviewer: Sponsor:

Description

We need to add a projects/android-toolchain directory which will download and build the Android SDK and all tools needed to be able to build Tor Browser for Android.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by gk

Priority: MediumHigh

Bumping prio.

comment:2 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:4 Changed 3 weeks ago by boklm

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808 removed
Status: newneeds_review

comment:5 in reply to:  3 Changed 3 weeks ago by boklm

Status: needs_reviewneeds_revision

Replying to sisbell:

commit: https://github.com/sisbell/tor-browser-build/commit/3ac1fe9c44a1ec20946896824cb06523e7370ef7

I did not try a build yet with this commit, but here are some first comments:

  • the format of the commit subjects should be Bug XXXX: description of the commit. So in this case, it should be Bug 26697: Add Android toolchain
  • it seems the var/setup in projects/android-toolchain/config is wrong:
      setup: |
        mkdir -p /var/tmp/dist
        unzip sdk.zip
    

The zip file will be extracted in the current directory instead of /var/tmp/dist. And sdk.zip is probably not the correct filename. Instead $rootdir/[% c("compiler_tarfile") %] should be used as the filename.

comment:6 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201809R removed
Note: See TracTickets for help on using tickets.