Opened 5 months ago

Closed 5 months ago

#26702 closed enhancement (implemented)

Remind authority operators that bandwidth files should be written atomcally

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: torspec, 035-removed-20180711, fast-fix, doc
Cc: Actual Points:
Parent ID: #26851 Points:
Reviewer: Sponsor:

Description (last modified by teor)

Tor reads bandwidth files when it's voting, around 50 minutes past every hour, and 20 minutes past hours when the consensus has failed.

We should recommend that authority operators generate and transfer bandwidth files between 5-15 or 35-45 minutes outside of 15-25 and 45-55 minutes past the hour. The best place for this might be in dir-spec or the bandwidth file spec.

Child Tickets

Change History (18)

comment:1 Changed 5 months ago by teor

Description: modified (diff)

It doesn't matter if the generator is remote or local, it still needs to be scheduled correctly.

comment:2 Changed 5 months ago by juga

I thought to create a crontab file in the Debian package, But because would be needed for other distributions and it's essential to run sbws, i'm thinking now to add it to sbws repo. Created #26740 for it.

comment:3 Changed 5 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:4 Changed 5 months ago by teor

Keywords: fast-fix doc added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Owner: set to teor
Status: newassigned

comment:5 Changed 5 months ago by teor

Description: modified (diff)
Status: assignedneeds_review

The appropriate place for this documentation is in the man page, under the V3BandwidthsFile option. It's the place that authority operators are most likely to look when configuring a bandwidth authority.

Please see my branch ticket26702 on https://github.com/teor2345/tor.git

(We could also document this requirement in sbws, but sbws does atomic symlinks, so it's only important when using scp from a different host.)

comment:6 Changed 5 months ago by teor

(We could also document this requirement in sbws, but sbws does atomic symlinks, so it's only important when using scp from a different host.)

I left a comment in #26740.

comment:7 Changed 5 months ago by teor

The distcheck travis CI on this doc-only branch failed, probably because of #26787.

comment:8 Changed 5 months ago by juga

Status: needs_reviewmerge_ready

lgtm

comment:9 Changed 5 months ago by nickm

I'm sorry; I can't find this branch. Are you sure it's where you say?

comment:10 Changed 5 months ago by juga

It seems it has been accidentally removed?

comment:11 in reply to:  9 Changed 5 months ago by teor

Replying to nickm:

I'm sorry; I can't find this branch. Are you sure it's where you say?

I forked torproject/tor yesterday so I could do pull requests. (GitHub doesn't support pull requests between repositories, unless they are in the same GitHub fork tree.) My old tor repository is at tor-old.

I have re-pushed the branch ticket26702 to ​https://github.com/teor2345/tor.git

comment:12 Changed 5 months ago by nickm

I don't think this is what we should recommend. I think that instead we should recommend that these files be replaced atomically, via rename. How would that be?

comment:13 Changed 5 months ago by teor

Parent ID: #25925#26851
Status: merge_readyneeds_revision

Ok, I think that's better, I'll update all the docs at once.

comment:14 Changed 5 months ago by teor

Summary: Remind authority operators that bandwidth files should be transferred outside the voting periodRemind authority operators that bandwidth files should be written atomcally

comment:15 Changed 5 months ago by teor

Status: needs_revisionmerge_ready

Please see my branch ticket26702-atomically on ​​https://github.com/teor2345/tor.git

comment:16 Changed 5 months ago by teor

The travis CI failed for this doc-only branch due to #26787

comment:17 Changed 5 months ago by teor

The appveyor CI failed for this doc-only branch, I opened #26853 to fix it.

comment:18 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.