Opened 11 days ago

Closed 4 days ago

#26703 closed defect (fixed)

Lower log level of "Scheduler type KIST has been enabled"

Reported by: pastly Owned by:
Priority: Very Low Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.2.9
Severity: Trivial Keywords: easy, kist, tor-scheduler, 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

I like seeing it, but that doesn't mean everyone should have to see it. Tor doesn't log about EWMA vs RR.

Child Tickets

Change History (7)

comment:1 Changed 11 days ago by dgoulet

Keywords: easy added
Type: enhancementdefect

In the early days of KIST, having that line was SO useful. I propose we put it in the summary line (if we can or in a new type of summary line) like this one:

[notice] Tor 0.3.4.0-alpha-dev (git-facde43b0e0ad3ea) running on Linux with Libevent 2.1.8-stable, OpenSSL 1.0.2n, Zlib 1.2.11, Liblzma 5.2.2, and Libzstd N/A.

comment:2 Changed 11 days ago by pastly

See https://gitweb.torproject.org/user/pastly/tor.git/log/?h=issue26703 for changing it to INFO.

I would support moving it to the summary.

comment:3 Changed 11 days ago by pastly

Status: newneeds_review

FWIW, I gave 5 minutes of effort to adding the scheduler type to the summary. It not as easy as log_info because the required stuff (get_scheduler_type_string() and the_scheduler) is static. Furthermore (and actually importantly), I don't think we've initialized the scheduler at the point the summary is logged.

Working off the assumption that we don't want to overcome these challenges, I'm moving this to needs_review.

comment:4 Changed 10 days ago by asn

Keywords: kist tor-scheduler added

comment:5 Changed 9 days ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:6 Changed 4 days ago by dgoulet

Reviewer: dgoulet

comment:7 Changed 4 days ago by dgoulet

Resolution: fixed
Status: needs_reviewclosed

Trivial fix. I'm good with log_info for now and we can work out later to have it in a status line.

Merged!

Note: See TracTickets for help on using tickets.