Opened 11 days ago

Closed 28 hours ago

#26712 closed defect (fixed)

EVP_PKEY_HKDF not defined in libressl, src/lib/crypt_ops/crypto_hkdf.c cannot compile

Reported by: cypherpunks Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: regression, compile-error, 035-must, 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description


Child Tickets

Change History (8)

comment:1 Changed 11 days ago by teor

Keywords: regression compilation-error added
Milestone: Tor: 0.3.5.x-final

comment:2 Changed 11 days ago by teor

Keywords: compile-error 035-must added; compilation-error removed

comment:3 Changed 9 days ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:4 Changed 9 days ago by nickm

Owner: set to nickm
Status: newaccepted

comment:5 Changed 9 days ago by nickm

Status: acceptedneeds_review

Possible fix in my branch bug26712 with PR at https://github.com/torproject/tor/pull/227 . Tested with openssl and libressl on Fedora.

comment:6 Changed 4 days ago by asn

Reviewer: asn

comment:7 Changed 29 hours ago by asn

Status: needs_reviewmerge_ready

I can verify that compilation fails with libressl on master, and that this patch makes it compile fine.

I only managed to test this with libressl built in /usr/local/lib. I tried to compile this with libressl built in a custom DESTDIR but I didn't manage to compile Tor properly like that.

Last edited 28 hours ago by asn (previous) (diff)

comment:8 Changed 28 hours ago by nickm

Resolution: fixed
Status: merge_readyclosed

Okay; merged to master

Note: See TracTickets for help on using tickets.