Opened 15 months ago

Last modified 14 months ago

#26754 needs_revision enhancement

stop using BUFFERS_PRIVATE

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: buffers
Cc: Actual Points:
Parent ID: #23878 Points:
Reviewer: Sponsor:

Description

Move the three users to the public API of buffers.h instead.

Patches in branch 'buffer-api-users' at https://gitgud.io/onionk/tor.git

Child Tickets

Change History (5)

comment:1 Changed 15 months ago by asn

Keywords: buffers added
Milestone: Tor: unspecified
Status: newneeds_review

comment:2 Changed 15 months ago by nickm

Status: needs_reviewneeds_revision

Hi, thanks for the patch!

I like the idea of doing this very much, but we need some approach here that doesn't involve using so many tmp buffers. This code is critical-path in Tor, and it would be better not to increase the number of copies or system calls.

comment:3 Changed 15 months ago by cypherpunks3

This code is critical-path in Tor, and it would be better not to increase the number of copies or system calls.

You said in #23878 two days earlier:

we don't need to worry about an extra copy too much.

What changed? Are there any benchmarks that show what the actual performance hit is for this change?

Last edited 15 months ago by cypherpunks3 (previous) (diff)

comment:4 in reply to:  2 Changed 14 months ago by cypherpunks3

Replying to nickm:

Ping.

How would you measure the real world performance impact of this change? If there isn't a way to measure it, how would we know if any alternative approach is impact-free?

comment:5 Changed 14 months ago by teor

Parent ID: #23878
Note: See TracTickets for help on using tickets.