Opened 10 days ago

Last modified 9 days ago

#26754 needs_revision enhancement

stop using BUFFERS_PRIVATE

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: buffers
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Move the three users to the public API of buffers.h instead.

Patches in branch 'buffer-api-users' at https://gitgud.io/onionk/tor.git

Child Tickets

Change History (2)

comment:1 Changed 9 days ago by asn

Keywords: buffers added
Milestone: Tor: unspecified
Status: newneeds_review

comment:2 Changed 9 days ago by nickm

Status: needs_reviewneeds_revision

Hi, thanks for the patch!

I like the idea of doing this very much, but we need some approach here that doesn't involve using so many tmp buffers. This code is critical-path in Tor, and it would be better not to increase the number of copies or system calls.

Note: See TracTickets for help on using tickets.