#26789 closed defect (fixed)

configure --disable-unittests causes build to fail when linking

Reported by: jchevali Owned by: rl1987
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-must? regression
Cc: rl1987 Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

Observed in tor 0.3.4.5-rc and alpha versions leading to it:

...
  CCLD     src/test/test-bt-cl
src/test/src_test_test_bt_cl-test_bt_cl.o: In function `crash':
[...]/src/test/test_bt_cl.c:43: undefined reference to `tor_assertion_failed_'
src/test/src_test_test_bt_cl-test_bt_cl.o: In function `main':
[...]/src/test/test_bt_cl.c:107: undefined reference to `init_logging'
[...]/src/test/test_bt_cl.c:108: undefined reference to `set_log_severity_config'
[...]/src/test/test_bt_cl.c:109: undefined reference to `add_stream_log'
[...]/src/test/test_bt_cl.c:110: undefined reference to `tor_log_update_sigsafe_err_fds'
[...]/src/test/test_bt_cl.c:112: undefined reference to `configure_backtrace_handler'
[...]/src/test/test_bt_cl.c:116: undefined reference to `clean_up_backtrace_handler'
[...]/src/test/test_bt_cl.c:117: undefined reference to `logs_free_all'
collect2: error: ld returned 1 exit status
Makefile:5218: recipe for target 'src/test/test-bt-cl' failed
make[1]: *** [src/test/test-bt-cl] Error 1
make[1]: Leaving directory '[...]'
Makefile:3468: recipe for target 'all' failed
make: *** [all] Error 2

Child Tickets

TicketStatusOwnerSummaryComponent
#26792closedrl1987tor-0.3.4.5-rc: fails to build when configured with `./configure --disable-unittests`Core Tor/Tor

Change History (12)

comment:1 Changed 17 months ago by nickm

Keywords: 034-must? regression added
Milestone: Tor: 0.3.4.x-final

comment:2 Changed 17 months ago by rl1987

Cc: rl1987 added

comment:3 Changed 17 months ago by toralf

commit b7fae0f48 was bisected to be the first bad commit (between 0.3.4.2-alpha and 0.3.4.3-alpha)

Last edited 17 months ago by toralf (previous) (diff)

comment:4 Changed 17 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

Will look into this (and #26792) in next few days.

comment:5 Changed 17 months ago by teor

Summary: configure --disable-unittests causes build to crashconfigure --disable-unittests causes build to fail when linking

Fix description, #26792 is a duplicate.

comment:7 Changed 17 months ago by rl1987

Status: acceptedneeds_review

comment:8 Changed 17 months ago by nickm

Hm. This seems reasonable for master, but the bug is reported against 0.3.4. We're going to need a fix that works there too.

comment:9 Changed 17 months ago by dgoulet

Reviewer: nickm
Status: needs_reviewneeds_revision

Seems nickm proposed that the branch should be based on maint-0.3.4 here (?).

comment:10 Changed 17 months ago by rl1987

Status: needs_revisionneeds_review

Pull request to maint-0.3.4: https://github.com/torproject/tor/pull/238

comment:11 Changed 17 months ago by nickm

Status: needs_reviewmerge_ready

Great -- I'll merge once I've given it a quick test.

comment:12 Changed 17 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Works fine -- both branches merged. Thanks!

Note: See TracTickets for help on using tickets.