Opened 13 months ago

Last modified 10 months ago

#26797 new defect

DirAuths should only read the V3BandwidthsFile once per vote

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, metrics, tor-bwauth
Cc: Actual Points:
Parent ID: #27047 Points:
Reviewer: Sponsor:

Description

Every time we read the file, we increase the risk of race conditions, where some code reads one version of the file, and other code reads another version.

See #26702 for details.

If we implement #21377, we should do this refactor first.

Child Tickets

TicketStatusOwnerSummaryComponent
#26827closedtorspec: DirAuths should only read the V3BandwidthsFile once per voteCore Tor/Tor
#26851closedteordoc: writing bandwidth files atomicallyCore Tor/Tor

Change History (3)

comment:1 Changed 10 months ago by juga

If #26851 can be closed (https://trac.torproject.org/projects/tor/ticket/26851#comment:5), i think this can be closed too.

comment:2 Changed 10 months ago by teor

We might want to fix this issue when metrics starts asking tor for bandwidth files.

comment:3 Changed 10 months ago by teor

Parent ID: #21377#27047
Note: See TracTickets for help on using tickets.