#26829 closed defect (implemented)

torspec: bandwidth file generators should write the file atomically

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix, doc, tor-dirauth, metrics, tor-bwauth, torspec
Cc: Actual Points:
Parent ID: #26851 Points:
Reviewer: mikeperry Sponsor:

Description

Generators should either:

  • write the file to a temporary location, then rename it to the final path, or
  • write the file to an archival location, then symlink it to the final path

Child Tickets

Change History (8)

comment:1 Changed 15 months ago by teor

Keywords: fast-fix doc added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Owner: set to teor
Parent ID: #26797#26851
Status: newassigned

comment:2 Changed 15 months ago by teor

Status: assignedneeds_review

Please see my branch ticket26829 on https://github.com/teor2345/torflow.git

comment:3 Changed 15 months ago by asn

Reviewer: mikeperry

comment:4 Changed 15 months ago by mikeperry

Status: needs_reviewmerge_ready

This sounds good to me! sorry for the delay.

comment:5 Changed 15 months ago by nickm

Who can merge this? I don't think I have (or should have!) commit permissions on torflow.

comment:6 Changed 15 months ago by nickm

The list of committers is: aagbsn mikeperry teor tom . Could one of you merge this, please?

comment:7 Changed 14 months ago by teor

Sorry for the typo, it's a torspec branch, not a torflow branch:

https://github.com/teor2345/torspec/tree/ticket26829

comment:8 Changed 14 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Oh, whoops!

Merged!

Note: See TracTickets for help on using tickets.