Opened 9 months ago

Closed 3 months ago

#26839 closed enhancement (implemented)

prop289: Make a relay remember last cell digests before SENDME

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop289, 035-roadmap-subtask, prop289-assigned-sponsor-v, 041-proposed-on-roadmap
Cc: Actual Points:
Parent ID: #26288 Points:
Reviewer: Sponsor: SponsorV

Description

From proposal 289, this would be phase one and quoting:

In phase one, both sides begin remembering their expected digests, and they learn how to parse sendme payloads. When they receive a sendme with payload version 1, they verify its digest and tear down the circuit if it's wrong. But they continue to send and accept payload version 0 sendmes.

Child Tickets

Change History (9)

comment:1 Changed 9 months ago by dgoulet

Keywords: 035-roadmap-subtask added
Sponsor: SponsorV

comment:2 Changed 9 months ago by dgoulet

Type: defectenhancement

comment:3 Changed 9 months ago by nickm

I think the best subsystem to implement this in would be in the relay_crypto.c area. The logical place to store it would be in relay_crypto_t, which is the shared state between two points on a Tor circuit.

comment:4 Changed 9 months ago by teor

Keywords: prop289-assigned-sponsor-v added

I think all prop#289 tickets are Sponsor V.

comment:5 Changed 8 months ago by dgoulet

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Deferring prop289 work to 036

comment:6 Changed 6 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:7 Changed 4 months ago by dgoulet

Milestone: Tor: 0.4.0.x-finalTor: 0.4.1.x-final

prop289 won't make it in 040. Feature freeze is in 7 days.

comment:8 Changed 4 months ago by teor

Keywords: 041-proposed-on-roadmap added

Let's review these tickets at the next meeting using our 041-proposed process.
They're on the roadmap, so the review should focus on ticket size and team capacity (and sponsor expectations).

comment:9 Changed 3 months ago by nickm

Resolution: implemented
Status: assignedclosed

Done as part of parent.

Note: See TracTickets for help on using tickets.