Opened 15 months ago

Last modified 2 months ago

#26844 needs_revision task

TBA: Investigate/Setup Fastlane

Reported by: sysrqb Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-8.5, TorBrowserTeam201908
Cc: igt0, gk, emmapeel, eighthave Actual Points:
Parent ID: #26782 Points:
Reviewer: Sponsor:

Description

Let's try it and see how well it works for us.
https://fastlane.tools/

In particular, does Fastlane provide an easy/useful way for integrating translations/localizations and deploying them (both for App stores and within the app). If this provides an easier way for publishing a new app and publishing app updates, then that is a bonus benefit of using this.

Child Tickets

Change History (23)

comment:1 Changed 11 months ago by eighthave

Cc: eighthave added

comment:2 Changed 11 months ago by eighthave

From a short discussion on IRC with antonela, emmapeel, and pili: regarding localized screenshots for android apps, I recommend using Fastlane Supply. The upside is that it can completely automate the procedure for taking screenshots. Adding a new language is just adding the locale name, and running it again. The downside is that it requires an Android dev to set it up by writing espresso tests.
But once setup, I think it should be relatively stable.

Also, if the screenshots are then commited to the project's git in the fastlane location, then F-Droid will automatically include them.

comment:3 Changed 10 months ago by gk

Keywords: TorBrowserTeam201812 added

comment:4 Changed 9 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:5 Changed 8 months ago by gk

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201901 removed

Moving tickets to February.

comment:6 Changed 7 months ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201902 removed

Moving remaining tickets to March.

comment:7 Changed 7 months ago by gk

Keywords: tbb-8.5 added

Tickets on our radar for 8.5

comment:8 Changed 7 months ago by eighthave

Weblate now directly supports Fastlane files, making managing trnaslations of the app store texts much easier. For example, here's F-Droid:
https://hosted.weblate.org/projects/f-droid/f-droid-metadata/

comment:9 Changed 7 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201903 removed

Moving tickets to April.

comment:10 Changed 6 months ago by sysrqb

Okay, I have a branch for this, pending user repo creation (#30088).

comment:11 in reply to:  8 Changed 6 months ago by sysrqb

Replying to eighthave:

Weblate now directly supports Fastlane files, making managing trnaslations of the app store texts much easier. For example, here's F-Droid:
https://hosted.weblate.org/projects/f-droid/f-droid-metadata/

Very nice! Thanks!

comment:12 Changed 6 months ago by sysrqb

Status: newneeds_review

I pushed a branch. It includes some images we don't currently use (but maybe we'll use them in the future). The directory adds an additional ~4MB, and I don't feel very strongly about keeping it. I'm also open to suggestions about using a different directory structure.

Currently, in the root there is the fastlane/ directory, everything under that is touched by fastlane (either synchronized from Google Play into the directory, or synchronized from those file to Google Play). The Fastfile and Appfile were created by fastlane. All the files and directories under fastlane/metadata/ were created by fastlane except featureGraphic.png, and the images under images/phoneScreenshots/. Fastlane can't synchronize those, so I added them manually.

The three README files can use some more work, but they should be a starting point. The image_repository/ directory is the directory mentioned earlier, and it is simply a place where we can track images that aren't currently being used but we want to stash them. I don't know if this is actually something we want/need.

Branch bug26844_0 - https://git.torproject.org/user/sysrqb/fastlane.git

comment:13 Changed 6 months ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed

comment:14 Changed 6 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201904R removed
Status: needs_reviewneeds_revision

Okay, that almost fell through the cracks (I am filtering all the reviews by the TorBrowserTeamYYYYMMR keyword), but here we are:

1) README

s/fastlast/fastlane/

2) 2015539345.txt

s/Tor Browser for Android/Tor Browser/g

3) Why do we have the Changelog for 8.5a9 and 8.5a10 twice (and we should add the Changelog for 8.5a11)

4) full_description.txt

There are some trailing whitespaces that are superfluous

s/Tor Browser for Android/Tor Browser/

I think the "Known issue:" is fixed as well as the note that we need Orbot.

5) icon.png

That's the old icon. We have new ones, thanks to #28622.

6) title.txt

s/Tor Browser for Android/Tor Browser

7) TBA Welcome Page@3x.png

Should we update that and the @1 and @2 versions to contain the newsletter signup line as well which we have since #29035?

8) File:Lead Image - Full Color.svg

That image still has the Sketch metadata in it (<!-- Generator: Sketch 51.2 (57519) - http://www.bohemiancoding.com/sketch -->). Let's remove that.

9) General

That's for the alpha releases right now. We should probably integrate the respective icon and text for the stable one as well given that we want to have different series. Not sure how that works, though.

Last edited 6 months ago by gk (previous) (diff)

comment:15 Changed 5 months ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201904 removed

Moving tickets to May

comment:16 Changed 5 months ago by eighthave

About changelogs, as far as I know, Google Play and F-Droid will only show the exact entry for a given APK. So that means each release needs a changelog txt file, even if the contents don't change. What lots of people do with these changelogs/release notes/whatsNew fields is always fill it up, so including important changes from previous releases until the 500 char max is reached. Not everyone does that.

We're setting up Fastlane on Orbot now:
https://github.com/n8fr8/orbot/pull/210

I recommend adding exiftool -all= *.png somewhere to strip all metadata from images. I don't know a metadata stripper for SVG.

comment:17 in reply to:  14 ; Changed 5 months ago by sysrqb

Replying to gk:

Okay, that almost fell through the cracks (I am filtering all the reviews by the TorBrowserTeamYYYYMMR keyword), but here we are:

1) README

s/fastlast/fastlane/

2) 2015539345.txt

s/Tor Browser for Android/Tor Browser/g

These are old changelogs (the changelogs we originally published with the releases). I don't think we should (basically) change history at this point.

3) Why do we have the Changelog for 8.5a9 and 8.5a10 twice (and we should add the Changelog for 8.5a11)
basically

There is one changelog per apk per release - so one for armv7 and another for x86. I only created one for the entire release, but it seems Google used that changelog and automatically created one for each apk.

4) full_description.txt

There are some trailing whitespaces that are superfluous

s/Tor Browser for Android/Tor Browser/

I think the "Known issue:" is fixed as well as the note that we need Orbot.

Done.

5) icon.png

That's the old icon. We have new ones, thanks to #28622.

Done.

6) title.txt

s/Tor Browser for Android/Tor Browser

Done.

7) TBA Welcome Page@3x.png

Should we update that and the @1 and @2 versions to contain the newsletter signup line as well which we have since #29035?

I created #29834 for this. I think we can update them later.

8) File:Lead Image - Full Color.svg

That image still has the Sketch metadata in it (<!-- Generator: Sketch 51.2 (57519) - http://www.bohemiancoding.com/sketch -->). Let's remove that.

Thanks for noticing this. Removed.

9) General

That's for the alpha releases right now. We should probably integrate the respective icon and text for the stable one as well given that we want to have different series. Not sure how that works, though.

Yes, I see two options here. The first option is we follow tor-browser-build and create one branch per series (master, maint-8.5, nightly (?)). The second option is only using the master branch and creating a different fastlane/ directory for each series, e.g. fastlane_stable/, fastlane_alpha/, fastlane_nightly/. Actually, if we use the second option, then we can create a common directory as fastlane/ or fastlane_shared/ where all of the shared files are stored (like the descriptions) and then we can create symlinks from both image_repository/ and fastlane/ in each series, as needed, for all shared resources.

I can begin this in the next patch.

I pushed a fixup commit on bug26844_0.

comment:18 in reply to:  16 Changed 5 months ago by sysrqb

Replying to eighthave:

I recommend adding exiftool -all= *.png somewhere to strip all metadata from images. I don't know a metadata stripper for SVG.

Thanks for the suggestion! It looks like they were clean.

$ exiftool -all= image_repository/*.png
    0 image files updated
   29 image files unchanged

For svg files, the best suggestion I found was opening them in inkscape and then saving it as an optimized SVG.

comment:19 Changed 5 months ago by sysrqb

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: needs_revisionneeds_review

comment:20 in reply to:  17 Changed 5 months ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201905R removed
Status: needs_reviewneeds_revision

Replying to sysrqb:

Replying to gk:

[snip]

2) 2015539345.txt

s/Tor Browser for Android/Tor Browser/g

These are old changelogs (the changelogs we originally published with the releases). I don't think we should (basically) change history at this point.

Right, sounds good.

3) Why do we have the Changelog for 8.5a9 and 8.5a10 twice (and we should add the Changelog for 8.5a11)
basically

There is one changelog per apk per release - so one for armv7 and another for x86. I only created one for the entire release, but it seems Google used that changelog and automatically created one for each apk.

I see. That's a bit sad. But on the other hand that is probably okay in case we need to have per-arch differences. I just wished the Changlogs/file names would indicate the architecture somehow to make it less confusing.

4) full_description.txt

There are some trailing whitespaces that are superfluous

s/Tor Browser for Android/Tor Browser/

I think the "Known issue:" is fixed as well as the note that we need Orbot.

Done.

Looks good. While re-reading the text is it still correct to say: "Give today, and Mozilla will match your gift"? I thought that was just for the year-end campaign? (I mean I'd would be cool if that were still true, but...)

[snip]

7) TBA Welcome Page@3x.png

Should we update that and the @1 and @2 versions to contain the newsletter signup line as well which we have since #29035?

I created #29834 for this. I think we can update them later.

Works for me.

[snip]

9) General

That's for the alpha releases right now. We should probably integrate the respective icon and text for the stable one as well given that we want to have different series. Not sure how that works, though.

Yes, I see two options here. The first option is we follow tor-browser-build and create one branch per series (master, maint-8.5, nightly (?)). The second option is only using the master branch and creating a different fastlane/ directory for each series, e.g. fastlane_stable/, fastlane_alpha/, fastlane_nightly/. Actually, if we use the second option, then we can create a common directory as fastlane/ or fastlane_shared/ where all of the shared files are stored (like the descriptions) and then we can create symlinks from both image_repository/ and fastlane/ in each series, as needed, for all shared resources.

Yes, please. The second option sounds pretty good to me.

I can begin this in the next patch.

Okay. Setting to needs_revision again.

comment:21 Changed 4 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:22 Changed 3 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:23 Changed 2 months ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving more tickets to August

Note: See TracTickets for help on using tickets.