#26859 closed enhancement (implemented)

Spec: improve contextual description of EXTEND->CREATE / CREATED->EXTENDED handling and payloads

Reported by: dmr Owned by: teor
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-spec
Cc: catalyst, asn, nickm, teor, atagar Actual Points:
Parent ID: #26860 Points:
Reviewer: Sponsor:

Description

catalyst noted in #tor-dev that 5.1.2 (EXTEND and EXTENDED) says nothing explicitly about an OR's (relays receiving an EXTEND or EXTEND2 cell) responsibility to send a corresponding CREATE/CREATE2 cell to the requested next node.

catalyst, asn, nickm, and I chatted a bit about it.
I bought up that 5.3 mentions an OR's role of translating EXTEND -> CREATE and CREATED -> EXTENDED and suggested we might reference that section from 5.1 and 5.1.2.

It's probably enough to do that, but if some other change makes more sense (when actually putting together the wording), do that.

Child Tickets

Change History (6)

comment:1 Changed 12 months ago by dmr

Cc: teor atagar added
Owner: set to dmr
Status: newassigned

Assigning to self - I'll try to take care of this within the next few weeks.

comment:2 Changed 12 months ago by teor

Owner: changed from dmr to teor
Parent ID: #26869

I had to fix this for prop#295 in #26869.

comment:3 Changed 12 months ago by teor

Parent ID: #26869#26860
Status: assignedneeds_review

I handled this in #26860, because the edits were interleaved.

comment:4 in reply to:  3 ; Changed 12 months ago by catalyst

Replying to teor:

I handled this in #26860, because the edits were interleaved.

Thanks! Looks good. I commented on one of the commits with a minor suggestion. And I updated pull request branch at https://github.com/torproject/torspec/pull/27

comment:5 in reply to:  4 Changed 12 months ago by teor

Replying to catalyst:

Replying to teor:

I handled this in #26860, because the edits were interleaved.

Thanks! Looks good. I commented on one of the commits with a minor suggestion. And I updated pull request branch at https://github.com/torproject/torspec/pull/27

I pushed a fixup, see #26860.

comment:6 Changed 12 months ago by catalyst

Resolution: implemented
Status: needs_reviewclosed

Implemented in the same branch as #26860.

Note: See TracTickets for help on using tickets.