Opened 10 months ago

Last modified 3 weeks ago

#26861 needs_review defect

Bump available ulimit in runc container in tor-browser-build

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201905R
Cc: sukhbir, tom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

tjr hit a build failure with ulimit set to 1024 (see: comment:7:ticket:26476). I've never seen this before, so I am not sure what the underlying problem is but we should fix it. It turns out that's easily doable by raising the limit in projects/common/runc-config.json. Not sure, what number we should pick, though, but tjr went with 65535.

Child Tickets

Change History (15)

comment:1 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201807R added
Status: newneeds_review

I think we don't need to set any limit. The reason we had this limit set is that it is in the default example configuration.

I am not sure however why other people were not affected by this issue. Maybe tjr's build machine has many cores, causing many gcc processes to be run in parallel and reaching the limit?

There is a patch for removing the limit in branch bug_26861:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26861&id=b7035b046a06b63edb2ca07e6e8d7afe3a5dc0bd

comment:2 Changed 10 months ago by gk

Tom, could you check whether that works for you?

comment:3 Changed 10 months ago by gk

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201807R removed

comment:4 Changed 9 months ago by rlimit

If the defaults in your container are sufficient for you, then there is no need to set them explicitly.
https://serverfault.com/questions/356962/where-are-the-default-ulimit-values-set-linux-centos

comment:5 Changed 9 months ago by gk

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808R removed

Moving review tickets to September

comment:7 Changed 9 months ago by traumschule

so just patch binutils as a prerequisite

edit: just with ;)

Last edited 9 months ago by traumschule (previous) (diff)

comment:8 Changed 8 months ago by gk

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201809R removed

Moving review tickets to October

comment:9 Changed 7 months ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

Moving reviews to November.

comment:10 Changed 6 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811R removed

Move review tickets to Decemeber.

comment:11 Changed 5 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201812R removed

Moving review tickets to 2019.

comment:12 Changed 4 months ago by gk

Keywords: TorBrowserTeam201902R added; TorBrowserTeam201901R removed

Moving our review tickets to February.

comment:13 Changed 3 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201902R removed

February is gone.

comment:14 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:15 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201904R removed

No April anymore, moving review tickets to May.

Note: See TracTickets for help on using tickets.