Opened 23 months ago

Closed 6 months ago

#26861 closed defect (fixed)

Bump available ulimit in runc container in tor-browser-build

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201912R
Cc: sukhbir, tom Actual Points:
Parent ID: Points:
Reviewer: gk Sponsor:

Description

tjr hit a build failure with ulimit set to 1024 (see: comment:7:ticket:26476). I've never seen this before, so I am not sure what the underlying problem is but we should fix it. It turns out that's easily doable by raising the limit in projects/common/runc-config.json. Not sure, what number we should pick, though, but tjr went with 65535.

Child Tickets

Change History (26)

comment:1 Changed 23 months ago by boklm

Keywords: TorBrowserTeam201807R added
Status: newneeds_review

I think we don't need to set any limit. The reason we had this limit set is that it is in the default example configuration.

I am not sure however why other people were not affected by this issue. Maybe tjr's build machine has many cores, causing many gcc processes to be run in parallel and reaching the limit?

There is a patch for removing the limit in branch bug_26861:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26861&id=b7035b046a06b63edb2ca07e6e8d7afe3a5dc0bd

comment:2 Changed 23 months ago by gk

Tom, could you check whether that works for you?

comment:3 Changed 22 months ago by gk

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201807R removed

comment:4 Changed 22 months ago by rlimit

If the defaults in your container are sufficient for you, then there is no need to set them explicitly.
https://serverfault.com/questions/356962/where-are-the-default-ulimit-values-set-linux-centos

comment:5 Changed 21 months ago by gk

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808R removed

Moving review tickets to September

comment:7 Changed 21 months ago by traumschule

so just patch binutils as a prerequisite

edit: just with ;)

Last edited 21 months ago by traumschule (previous) (diff)

comment:8 Changed 20 months ago by gk

Keywords: TorBrowserTeam201810R added; TorBrowserTeam201809R removed

Moving review tickets to October

comment:9 Changed 19 months ago by gk

Keywords: TorBrowserTeam201811R added; TorBrowserTeam201810R removed

Moving reviews to November.

comment:10 Changed 18 months ago by gk

Keywords: TorBrowserTeam201812R added; TorBrowserTeam201811R removed

Move review tickets to Decemeber.

comment:11 Changed 17 months ago by gk

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201812R removed

Moving review tickets to 2019.

comment:12 Changed 16 months ago by gk

Keywords: TorBrowserTeam201902R added; TorBrowserTeam201901R removed

Moving our review tickets to February.

comment:13 Changed 15 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201902R removed

February is gone.

comment:14 Changed 14 months ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:15 Changed 13 months ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201904R removed

No April anymore, moving review tickets to May.

comment:16 Changed 12 months ago by gk

Keywords: TorBrowserTeam201906R added; TorBrowserTeam201905R removed

Moving reviews over to June.

comment:17 Changed 11 months ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201906R removed

No reviews in June 2019 anymore, moving them.

comment:18 Changed 10 months ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907R removed

No July any longer.

comment:19 Changed 9 months ago by gk

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201908R removed

No August anymore.

comment:20 Changed 8 months ago by pili

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201909R removed

We're now in October, moving September outstanding reviews to October

comment:21 Changed 7 months ago by pili

Keywords: TorBrowserTeam201911 added

Moving tickets to November 2019

comment:22 Changed 7 months ago by gk

Keywords: TorBrowserTeam201911R added; TorBrowserTeam201910R removed

There is no way to do reviews in October 2019 anymore.

comment:23 Changed 7 months ago by gk

Keywords: TorBrowserTeam201911 removed

No need for duplicate keyword.

comment:24 Changed 6 months ago by gk

Keywords: TorBrowserTeam201912R added; TorBrowserTeam201911R removed

We are in December now.

comment:25 Changed 6 months ago by pili

Reviewer: gk

gk to review this tickets

comment:26 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

We have no good way to reproduce the issue anymore but I think the solution in boklm's bug_26861 is a reasonable one to try. I went ahead with that and merged it into master (commit b6aeb0654a1e97feae322f2249b2a15d5b995085).

Note: See TracTickets for help on using tickets.