Opened 10 months ago

Last modified 9 months ago

#26863 reopened enhancement

display onionoo and RS version on RS pages

Reported by: nusenu Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #27064 Points:
Reviewer: Sponsor:

Description

it would be nice to have this info shown for debugging and bug reporting purposes
since it is not always clear what is deployed

Child Tickets

Change History (10)

comment:2 Changed 10 months ago by irl

Parent ID: 27064

comment:3 Changed 10 months ago by nusenu

Parent ID: 27064#27064

https://metrics.torproject.org/rs.html#toprelays

this seems odd:

Information for relays was published: UTC.
Information for bridges was published: UTC.

Onionoo version: /

(works on relay level pages)

Last edited 10 months ago by nusenu (previous) (diff)

comment:4 Changed 10 months ago by irl

Resolution: fixed
Status: merge_readyclosed

Ok. I will make a new ticket for this. I see what has happened.

comment:5 Changed 9 months ago by nusenu

Resolution: fixed
Status: closedreopened

the RS version is not shown on the page, is it?

comment:6 Changed 9 months ago by irl

RS doesn't have versions.

comment:7 Changed 9 months ago by nusenu

how about displaying the git commit id?

comment:8 Changed 9 months ago by irl

This would force us to build metrics-web from git, but we distribute tarballs without the git information and expect the build to be reproducible using this. We would break our reproducible builds if different things happened building for the tarball vs from git. Knowing the date and time of the request should be enough for a member of the metrics team to identify what version of the code was running at the time.

comment:9 in reply to:  8 Changed 9 months ago by nusenu

Replying to irl:

This would force us to build metrics-web from git, but we distribute tarballs without the git information

that could be solved by writing the git commit id into a text file when you create the tarball?

comment:10 Changed 9 months ago by irl

Our release process is quite manual, adding more steps at the moment would probably just lead to errors later on. Perhaps if someone wanted to write an ant patch we would merge it. In the future we want to have more automation in our releases and deployment, and then probably we would revisit this. Until then, we're not going to have meaningful version numbers for relay search.

Probably it is best to close this ticket for now, and file a ticket on metrics-web for looking at adding the git commit reference there during the build and release processes.

Note: See TracTickets for help on using tickets.