Opened 2 months ago

Closed 8 weeks ago

#26873 closed defect (fixed)

FTBFS on GNU/Hurd: no PATH_MAX

Reported by: paulusASol Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor Version:
Severity: Normal Keywords: 033-backport 034-backport
Cc: paul@… Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

PATH_MAX is undeclared on GNU/Hurd,
thus tor fails to compile since version 0.3.3

A build log of debian is available at https://buildd.debian.org/status/fetch.php?pkg=tor&arch=hurd-i386&ver=0.3.4.5-rc-1&stamp=1531586376&raw=0

The appended patches replace tor_snprintf with tor_asprintf.

Child Tickets

Attachments (1)

tor_path_max.patch (2.7 KB) - added by paulusASol 2 months ago.
Patch proposal

Download all attachments as: .zip

Change History (4)

Changed 2 months ago by paulusASol

Attachment: tor_path_max.patch added

Patch proposal

comment:1 Changed 2 months ago by nickm

Keywords: 033-backport 034-backport added
Milestone: Tor: 0.3.5.x-final
Status: newneeds_review

comment:2 Changed 8 weeks ago by nickm

Reviewer: nickm

comment:3 Changed 8 weeks ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.3.x-final
Resolution: fixed
Status: needs_reviewclosed

This looks good to me, and it doesn't seem to break anything. Merged to 0.3.3 and forward. Thank you for the patch!

Note: See TracTickets for help on using tickets.