Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#26874 closed defect (fixed)

Investigate UNC path restrictions failure in Tor Browser 8.0a9

Reported by: gk Owned by: pospeselr
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-proxy-bypass, TorBrowserTeam201808R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Filippo Cavallarin reported that the UNC path restrictions that got made available through https://bugzilla.mozilla.org/show_bug.cgi?id=1413868 are not working in Tor Browser 8.0a9. Surprisingly, Tor Browser 7.5.6 and Firefox 60.1.0 ESR are fine.

Child Tickets

Change History (5)

comment:1 Changed 4 months ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:2 Changed 4 months ago by boklm

Cc: tbb-team added

comment:3 Changed 3 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:4 Changed 3 months ago by pospeselr

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: assignedneeds_review

Fix for #26874.

https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_26874

This issue also exists in ESR60 and any fix will need to be uplifted.

comment:5 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

I reverted the slightly different patch we got from Valentin Gosu for 60.1.0esr (that's done in commit bd4abf8ba8f4e1aea2acd4b895274f646ed951a8) and cherry-picked the one that meanwhile landed on mozilla-esr60 on top of it (done in commit bd4abf8ba8f4e1aea2acd4b895274f646ed951a8). Then I cherry-picked the fix for this issue which Mozilla just pushed to its mozilla-esr60 repo (commit dae353ff5f2d033b9b87ebf2a5f833c87068d4a3). Everything is on tor-browser-60.1.0esr-8.0-1.

Thus, we should be good here now, thanks everyone.

Last edited 3 months ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.