Opened 2 years ago

Closed 2 years ago

#26890 closed defect (fixed)

Redefine coverity version of the BUG macro

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-must fast-fix ci coverity
Cc: Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:


Our BUG macro definition is all wrong for coverity.

We shouldn't be including coverity_panic, since hitting a BUG doesn't actually mean Tor will crashed, and we shouldn't imply that the condition might be visited anyway. We should just do "#define BUG(x) (x)" when we're building with coverity.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by nickm

Status: assignedneeds_review

Please review my branch ticket26890

comment:2 Changed 2 years ago by asn

Reviewer: teor

comment:3 Changed 2 years ago by teor

Status: needs_reviewneeds_revision

This looks good to me.

Please remove the comment:

 // We use this "deadcode_dummy__" trick to prevent coverity from
 // complaining about unreachable bug cases.

Then we're ready to merge!

comment:4 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed

fixed and merged!

Note: See TracTickets for help on using tickets.